Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[master] Add pkg.installed show installable version in test mode #63986

Merged

Conversation

nicholasmhughes
Copy link
Collaborator

What does this PR do?

See issue for details.

What issues does this PR fix or reference?

Fixes: #63985

Previous Behavior

Previously, pkg.installed only showed installed as the version for new package installs when run in test mode.

local:
----------
          ID: things
    Function: pkg.installed
      Result: None
     Comment: The following packages would be installed/updated: unzip
     Started: 18:06:05.586891
    Duration: 21196.532 ms
     Changes:   
              ----------
              unzip:
                  ----------
                  new:
                      installed
                  old:

Summary for local
------------
Succeeded: 1 (unchanged=1, changed=1)
Failed:    0
------------
Total states run:     1
Total run time:  21.197 s

New Behavior

Now the state shows the intended version to install in test mode.

local:
----------
          ID: things
    Function: pkg.installed
      Result: None
     Comment: The following packages would be installed/updated: unzip
     Started: 18:12:55.880310
    Duration: 774.975 ms
     Changes:   
              ----------
              unzip:
                  ----------
                  new:
                      6.0-23+deb10u3
                  old:

Summary for local
------------
Succeeded: 1 (unchanged=1, changed=1)
Failed:    0
------------
Total states run:     1
Total run time: 774.975 ms

Merge requirements satisfied?

[NOTICE] Bug fixes or features added to Salt require tests.

Commits signed with GPG?

Yes

Please review Salt's Contributing Guide for best practices.

See GitHub's page on GPG signing for more information about signing commits with GPG.

@nicholasmhughes nicholasmhughes requested a review from a team as a code owner March 28, 2023 19:38
@nicholasmhughes nicholasmhughes requested review from Ch3LL and removed request for a team March 28, 2023 19:38
@salt-project-bot-prod-environment salt-project-bot-prod-environment bot changed the title Add pkg.installed show installable version in test mode [master] Add pkg.installed show installable version in test mode Mar 28, 2023
@Ch3LL Ch3LL merged commit e4ba3fd into saltstack:master Apr 5, 2023
@nicholasmhughes nicholasmhughes deleted the add-pkg.installed-new-version branch April 6, 2023 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE REQUEST] pkg.installed test mode should show installable version
2 participants