Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rpm: Properly detect other ARMv7 (32 Bit) arches #60996

Merged
merged 4 commits into from
Dec 1, 2022

Conversation

mariushoch
Copy link
Contributor

@mariushoch mariushoch commented Oct 4, 2021

Similar to x86 32bit (i386, i486, …) there are several ARMv7 architectures that can be found alongside on one device. Salt should properly handle these and treat them all the same (if on such a ARMv7 device).
See also the current list at https://github.com/rpm-software-management/yum/blob/master/rpmUtils/arch.py (from which salt's list is derived).

What does this PR do?

This enables salt to properly detect other, usually compatible, ARM arches when handling rpm packages on a ARMv7 device.

What issues does this PR fix or reference?

Fixes: #60994

Previous Behavior

(on an ARMv7 device running Fedora 34)

# salt-call pkg.normalize_name ffmpeg-4.4-6.fc34.armv7hnl
local:
    ffmpeg-4.4-6.fc34.armv7hnl

New Behavior

(on an ARMv7 device running Fedora 34)

# salt-call pkg.normalize_name ffmpeg-4.4-6.fc34.armv7hnl
local:
    ffmpeg-4.4-6.fc34

Merge requirements satisfied?

[NOTICE] Bug fixes or features added to Salt require tests.

Commits signed with GPG?

No

Please review Salt's Contributing Guide for best practices.

See GitHub's page on GPG signing for more information about signing commits with GPG.

@mariushoch mariushoch requested a review from a team as a code owner October 4, 2021 13:56
@mariushoch mariushoch requested review from dhiltonp and removed request for a team October 4, 2021 13:56
@mariushoch mariushoch force-pushed the rpm-armv7 branch 3 times, most recently from 5995ef4 to a3080f9 Compare October 4, 2021 18:33
Like it is currently being done for the different
x86 arches (i386, i486, ...).
@Ch3LL Ch3LL added the P1 Priority 1 label Oct 10, 2022
Copy link
Contributor

@dmurphy18 dmurphy18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs to pass tests, otherwise looks good

@dmurphy18 dmurphy18 added the Sulfur v3006.0 release code name and version label Nov 8, 2022
Copy link
Contributor

@dmurphy18 dmurphy18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to add a changelog for the changes

@dmurphy18
Copy link
Contributor

@mariushoch Are you still interested in this PR ?, if unresponsive the PR shall be closed after several days.
Everything is good except need to add a changelog entry

@mariushoch
Copy link
Contributor Author

@mariushoch Are you still interested in this PR ?, if unresponsive the PR shall be closed after several days. Everything is good except need to add a changelog entry

Thanks for having a look. Added 👍

@Ch3LL Ch3LL merged commit 598c0ae into saltstack:master Dec 1, 2022
@mariushoch mariushoch deleted the rpm-armv7 branch December 3, 2022 23:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1 Priority 1 Sulfur v3006.0 release code name and version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Doesn't recognize some packages as installed on ARMv7 Fedora 34
4 participants