-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rpm: Properly detect other ARMv7 (32 Bit) arches #60996
Conversation
5995ef4
to
a3080f9
Compare
Like it is currently being done for the different x86 arches (i386, i486, ...).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs to pass tests, otherwise looks good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to add a changelog for the changes
@mariushoch Are you still interested in this PR ?, if unresponsive the PR shall be closed after several days. |
Thanks for having a look. Added 👍 |
Similar to x86 32bit (i386, i486, …) there are several ARMv7 architectures that can be found alongside on one device. Salt should properly handle these and treat them all the same (if on such a ARMv7 device).
See also the current list at https://github.com/rpm-software-management/yum/blob/master/rpmUtils/arch.py (from which salt's list is derived).
What does this PR do?
This enables salt to properly detect other, usually compatible, ARM arches when handling rpm packages on a ARMv7 device.
What issues does this PR fix or reference?
Fixes: #60994
Previous Behavior
(on an ARMv7 device running Fedora 34)
New Behavior
(on an ARMv7 device running Fedora 34)
Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
No
Please review Salt's Contributing Guide for best practices.
See GitHub's page on GPG signing for more information about signing commits with GPG.