Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sub state return #57993

Merged
merged 6 commits into from
Oct 7, 2020
Merged

Sub state return #57993

merged 6 commits into from
Oct 7, 2020

Conversation

Akm0d
Copy link
Contributor

@Akm0d Akm0d commented Jul 21, 2020 •
edited
Loading

What does this PR do?

Adds the ability for states to have sub state returns. For example, if you are running a state that runs several external states under a different engine, you can now add those external state runs individually to the "sub_state_run" key of the state return. They will be parsed and printed alongside the salt state runs.

Commits signed with GPG?

Yes

@Akm0d Akm0d added the Feature new functionality including changes to functionality and code refactors, etc. label Jul 21, 2020
@Akm0d Akm0d requested a review from a team as a code owner July 21, 2020 02:29
@ghost ghost requested review from krionbsd and removed request for a team July 21, 2020 02:29
@Akm0d Akm0d mentioned this pull request Jul 21, 2020
Closed
3 tasks
krionbsd
krionbsd previously approved these changes Jul 23, 2020
View reviewed changes
@krionbsd krionbsd added this to the Approved milestone Jul 23, 2020
@krionbsd krionbsd added the Magnesium Mg release after Na prior to Al label Jul 23, 2020
waynew
waynew reviewed Jul 23, 2020
View reviewed changes
salt/state.py Show resolved Hide resolved
tests/unit/test_state.py Show resolved Hide resolved
tests/unit/test_state.py Show resolved Hide resolved
Akm0d
Akm0d commented Jul 23, 2020
View reviewed changes
doc/ref/states/writing.rst Outdated Show resolved Hide resolved
@Akm0d Akm0d changed the title Sub state return [WIP] Sub state return Jul 23, 2020
@Akm0d Akm0d changed the title [WIP] Sub state return Sub state return Jul 24, 2020
@Akm0d Akm0d force-pushed the sub_state_return branch from f4fd777 to 4c67e61 Compare July 24, 2020 07:01
@Akm0d Akm0d requested review from waynew and krionbsd July 24, 2020 08:40
krionbsd
krionbsd previously approved these changes Jul 24, 2020
View reviewed changes
thatch45
thatch45 previously approved these changes Jul 27, 2020
View reviewed changes
@waynew
Copy link
Contributor

waynew commented Aug 31, 2020

@Akm0d looks like this one needs pre-commit hooks

@waynew
Copy link
Contributor

waynew commented Aug 31, 2020

Also waiting on saltstack/salt-enhancement-proposals#32

@Akm0d Akm0d requested review from thatch45 and krionbsd October 6, 2020 19:11
@dwoz dwoz merged commit cfca39c into saltstack:master Oct 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krionbsd krionbsd krionbsd approved these changes

@twangboy twangboy twangboy approved these changes

@Ch3LL Ch3LL Ch3LL approved these changes

@waynew waynew Awaiting requested review from waynew

@thatch45 thatch45 Awaiting requested review from thatch45

Assignees
No one assigned
Labels
Feature new functionality including changes to functionality and code refactors, etc. Magnesium Mg release after Na prior to Al
Projects
None yet
Milestone
Approved
Development

Successfully merging this pull request may close these issues.
8 participants
@Akm0d @waynew @thatch45 @Ch3LL @twangboy @krionbsd @dwoz @sagetherage