Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Distro is now a hard dependency #57151

Merged
merged 1 commit into from
May 12, 2020
Merged

Distro is now a hard dependency #57151

merged 1 commit into from
May 12, 2020

Conversation

s0undt3ch
Copy link
Collaborator

@s0undt3ch s0undt3ch commented May 8, 2020 •
edited
Loading

What does this PR do?

See title

What issues does this PR fix or reference?

Refs #55310
Refs #55835
Closes #55410

@s0undt3ch s0undt3ch requested a review from a team as a code owner May 8, 2020 08:40
@ghost ghost requested review from garethgreenaway and removed request for a team May 8, 2020 08:41
@dwoz dwoz requested a review from dmurphy18 May 10, 2020 00:33
@dwoz dwoz merged commit fe075aa into saltstack:master May 12, 2020
@s0undt3ch s0undt3ch deleted the hotfix/distro branch May 12, 2020 06:19
@sagetherage sagetherage added the ZRelease-Sodium retired label label May 18, 2020
@agraul
Copy link
Contributor

agraul commented Feb 16, 2021

Could you share the reason for making distro a hard dependency for all supported Python versions, even those who support from platform import linux_distribution (e.g. Python 3.6)? Just curios, I did not expect the old way to go away so soon.

@s0undt3ch
Copy link
Collaborator Author

Removed in Py3.8 and since we will have to move to distro, we just stop maintaining two different ways of getting the data.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@garethgreenaway garethgreenaway garethgreenaway approved these changes

@dmurphy18 dmurphy18 dmurphy18 approved these changes

Assignees
No one assigned
Labels
ZRelease-Sodium retired label
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@s0undt3ch @agraul @garethgreenaway @dmurphy18 @dwoz @sagetherage