Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port #51470 to master #56694

Merged
merged 4 commits into from
Apr 22, 2020
Merged

Port #51470 to master #56694

merged 4 commits into from
Apr 22, 2020

Conversation

terminalmage
Copy link
Contributor

See #51470

@jgleissner @terminalmage
Do not treat MSI auth support as hard dependency
c3ce53e 
On systems that lack MSI authentication support, only fail if MSI is actually
used. This allows users on older versions of msrestazure to use the azurearm
back-end.
@jgleissner @terminalmage
catch SystemError instead of BaseException
ee53f31
@terminalmage terminalmage requested a review from a team as a code owner April 18, 2020 07:04
@ghost ghost requested review from garethgreenaway and removed request for a team April 18, 2020 07:04
@terminalmage terminalmage mentioned this pull request Apr 18, 2020
Merged
@dwoz dwoz merged commit 1ce5f24 into saltstack:master Apr 22, 2020
@sagetherage sagetherage added the ZRelease-Sodium retired label label May 18, 2020
@terminalmage terminalmage deleted the bp-51470 branch February 12, 2024 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dwoz dwoz dwoz approved these changes

@garethgreenaway garethgreenaway Awaiting requested review from garethgreenaway

Assignees
No one assigned
Labels
master-port ZRelease-Sodium retired label
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@terminalmage @dwoz @garethgreenaway @sagetherage @jgleissner