Fallback to disabled LG_INCLUDE_INDIRECT when DC is unavailable #55780
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've used ERROR_ACCESS_DENIED, NERR_DCNotFound and RPC_S_SERVER_UNAVAILABLE (taken from https://docs.microsoft.com/en-us/windows/win32/api/lmaccess/nf-lmaccess-netusergetlocalgroups) to check the exception, as other don't make much sense for checking. While NERR_DCNotFound probably won't occur, might be also good to check, so I've included it apart from what was mentioned in #54809 |
|
re-run pr-windows2019-py3 |
dwoz
approved these changes
Jan 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes issue when DC is unavailable and Salt Minion tries to retrieve list of groups the running user is member of.
What issues does this PR fix or reference?
#54809
Previous Behavior
Minion also tries to resolve indirect groups, which causes minion to fail with exception which causes the service to restart indefinitely.
New Behavior
Minion tries to resolve only direct groups if indirect resolving fails, causing service to start properly if there is any issue with DC
Tests written?
Yes
Commits signed with GPG?
Yes