Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for package test issues - partial WIP #55704

Closed
wants to merge 2 commits into from

Conversation

dmurphy18
Copy link
Contributor

What does this PR do?

Fix packaging tests that were getting skipped

What issues does this PR fix or reference?

#55524

Previous Behavior

integration/states/test_pkgrepo.py and integration/states/test_pkg.py tests were getting skipped due to state functions being included in requires_salt_modules checking.

New Behavior

integration/states/test_pkgrepo.py now passes successfully.
integration/states/test_pkg.py has 4 errors due to incorrect functionality in salt not passing tests.
WIP saving tests over Christmas break

Tests written?

Fixing test files

Commits signed with GPG?

No

Please review Salt's Contributing Guide for best practices.

See GitHub's page on GPG signing for more information about signing commits with GPG.

@dmurphy18 dmurphy18 requested a review from a team as a code owner December 19, 2019 22:22
@ghost ghost requested a review from cmcmarrow December 19, 2019 22:22
@dmurphy18
Copy link
Contributor Author

test_pkg_011_latest_only_upgrade failing due to installing on upgrade when it should not
test_pkg_013_installed_with_comparison_operator failing probably due to test_pkg_011_latest_only_upgrade failing similarly with test_pkg_014_installed_missing_release, and test_pkg_015_installed_held

@s0undt3ch
Copy link
Collaborator

See #55707

@dmurphy18 dmurphy18 closed this Jan 9, 2020
@dmurphy18 dmurphy18 deleted the fix_issue_55524 branch August 4, 2020 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants