Remove NO_MOCK* reintroduced by PR #55589 #55675
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
39742b1 to
e441166
Compare
e441166 to
4dcb458
Compare
|
@github-abcde @dwoz you surely want to have a look at this PR |
github-abcde
approved these changes
Dec 17, 2019
|
@cbosdo If I see correctly, @s0undt3ch already fixed that in #55671 (which is not yet merged) |
|
#55671 has been merged, still, Thank You for your PR. Closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fix NO_MOCK uses breaking tests.
What issues does this PR fix or reference?
It fixes PR #55589
Tests written?
No - actually fixing the tests
Commits signed with GPG?
Yes