Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to Venafi module #55267

Closed
wants to merge 5,425 commits into from
Closed

Updates to Venafi module #55267

wants to merge 5,425 commits into from

Conversation

arykalin
Copy link
Contributor

@arykalin arykalin commented Nov 12, 2019

What does this PR do?

Transitions solution to Venafi preferred integration interface (VCert-Python) and updated to align with Venafi standard use cases for DevOps

Copy of #54695 merged with master branch

What issues does this PR fix or reference?

Restores interoperability with Venafi Cloud

Previous Behavior

Supported only Venafi Cloud

New Behavior

Adds support for Venafi Trust Protection Platform

Tests written?

Yes

Commits signed with GPG?

No

cmcmarrow and others added 30 commits June 24, 2019 15:08

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Update pillar.py
Forward port PR 53412 to Develop
[develop] Minor fixes/adjustments to the new CI pipelines
* Improved stability of cpan module
- Added command line options for cpan module installation
- Give many more details when things do change
- Parse cpan config using literal_eval, which is cleaner and more stable
  than the line-by-line parsing
- rename 'show_config' to 'config' to remove redundancy
- Rebuilt all command strings as lists to facilitate adding more options in the future
- added a "get cpan binary" function to facilitate expansion to cpanm
  and cpanp in the future
* Solves #2130
- cpan module returns version number
- created cpan state module
* Allow mirrors to be passed as a comma-separated string or as a list
* Install a cpan module that has no dependencies
* Added cpan state to docs, correct name for centos pkg
CI Pipelines. Timeout after getting a node. Report exit code.
As s3.query already knows how to quote paths, don't quote the passed in
path: s3.query will handle it.
Provide more information on the returner's "function not found error"
@arykalin arykalin requested a review from a team as a code owner November 12, 2019 13:10
@ghost ghost requested a review from garethgreenaway November 12, 2019 13:10
@arykalin arykalin changed the title Master venafi fix Updates to Venafi module Nov 13, 2019
@waynew
Copy link
Contributor

waynew commented Nov 13, 2019

@arykalin I think we'll still need to rebase on master - right now it's trying to merge 5,000+ commits 🙃

If you need help with that, let me know!

@arykalin
Copy link
Contributor Author

@arykalin I think we'll still need to rebase on master - right now it's trying to merge 5,000+ commits

If you need help with that, let me know!

Looks like I'll need to copy changed file to clean branch. I tried to rebase, but it is not possible since our commits are mixed with other commits from develop branch. I tried cherry pick but it cause this 5000+ commits

@arykalin arykalin closed this Nov 13, 2019
@arykalin
Copy link
Contributor Author

@waynew created #55286

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.