Redo "Import abstract base classes from collection.abc in python 3.3+" #54834
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR reintroduces #54309
Starting from Python 3.3 abstract base classes from
collections
was moved tocollections.abc
. For backward compatibility those classes can be imported fromcollections
directly. Since Python 3.7, importing abstract base classes fromcollections
directly leads to this warning:This PR moves imports of abstract base classes from
collections
tocollections.abc
in compatible versions of Python (with a falback to importing fromcollections
).What issues does this PR fix or reference?
This PR fixes #52120
This has been previously fixed in #49487 but it seems the fix was incomplete.
Commits signed with GPG?
No