Allow our custom yaml dumper to NamespacedDictWrapper objects (2018.3 branch) #49411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This special dict class did not have a representer assigned to it, so PyYAML would raise an exception when attempting to dump it. This also removes the name overriding, as its implementation was ill-conceived and will be deprecated in a later branch (it's only used in this one place so deprecating should be of no-to-minimal impact).
Nothing in Salt uses this now.
gtmanfred
approved these changes
Aug 29, 2018
rallytime
approved these changes
Aug 30, 2018
|
Refs #49269 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(This is #49408 opened against the 2018.3 branch)
This special dict class did not have a representer assigned to it, so PyYAML would raise an exception when attempting to dump it.
This also removes the class name overriding and deprecates the NamespacedDictWrapper's ability to do so, as it was A) incorrectly implmented and B) is no longer used by anything in Salt.