RequestContext (w/lint) #28249
Closed
RequestContext (w/lint) #28249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
finally will be run even if self.exit() is called.
```
Traceback (most recent call last):
File "/home/jacksontj/.virtualenvs/salt/bin/salt-run", line 10, in <module>
execfile(__file__)
File "/home/jacksontj/src/salt/scripts/salt-run", line 10, in <module>
salt_run()
File "/home/jacksontj/src/salt/salt/scripts.py", line 337, in salt_run
client.run()
File "/home/jacksontj/src/salt/salt/cli/run.py", line 47, in run
if isinstance(ret, dict) and 'retcode' in ret:
UnboundLocalError: local variable 'ret' referenced before assignment
```
Inspired by saltstack#23373 The basic issue we ran into is that the loader is injecting globals directly into the global namespace. This means that these injected values are not thread or coroutine safe-- meaning we can never do more than one thing at a time. Instead of multiprocessing everything to death-- we can simply use a stack_context to nicely handle this down in the core. As far as the module authors/users are concerned nothing has changed-- but the storage behind the scenes is now per-JID. This same set of classes can easily be used to store additional data (next candidates are reactors, master MWorker tasks, etc.).
While debugging in here I noticed that the style varied a bit-- so this normalizes it to one clean one :)
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs #27843 and adds some small lint fixes.