Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial commit of Salt Package Manager #24896

Merged
merged 9 commits into from
Jun 23, 2015
Merged

Initial commit of Salt Package Manager #24896

merged 9 commits into from
Jun 23, 2015

Conversation

techhat
Copy link
Contributor

@techhat techhat commented Jun 23, 2015

No description provided.

@techhat
Copy link
Contributor Author

techhat commented Jun 23, 2015

Let me get some docs in before we merge this.

@jfindlay jfindlay added Core relates to code central or existential to Salt Expert Change pending-changes The pull request needs additional changes before it can be merged labels Jun 23, 2015
@cachedout
Copy link
Contributor

Way awesome!

@techhat
Copy link
Contributor Author

techhat commented Jun 23, 2015

Docs are added, you may merge when ready.

@cachedout
Copy link
Contributor

QA, we will need some test coverage for this new feature. I will file a new issue.

@cachedout cachedout mentioned this pull request Jun 23, 2015
Closed
@nmadhok
Copy link
Contributor

nmadhok commented Jun 23, 2015

This is awesome! Need to start working on restructuring Salt Formulas. Let's get together sometime!

@rallytime
Copy link
Contributor

Double awesome!

@rallytime rallytime removed the pending-changes The pull request needs additional changes before it can be merged label Jun 23, 2015
@aboe76
Copy link
Contributor

aboe76 commented Jun 23, 2015

This is a nicely done :) 👍

cro added a commit that referenced this pull request Jun 23, 2015
@cro
Merge pull request #24896 from techhat/spm
18b9a5d 
Initial commit of Salt Package Manager
@cro cro merged commit 18b9a5d into saltstack:develop Jun 23, 2015
@techhat techhat deleted the spm branch June 24, 2015 02:33
s0undt3ch
s0undt3ch reviewed Jun 24, 2015
View reviewed changes
doc/topics/spm/index.rst
The version of the package. While it is up to the organization that manages this
package, it is suggested that this version is specified in a ``YYYYMM`` format.
For instance, if this version was released in June 2015, the package version
should be ``201506``. If multiple released are made in a month, the ``releasee``
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

releasee -> release?

@aboe76
Copy link
Contributor

aboe76 commented Jun 25, 2015

@techhat will you add spm to setup.py so we can build it and test it?

@s0undt3ch
Copy link
Collaborator

@aboe76 setup.py now correctly installs the spm script, was that what you were referring to? Is there something else missing?

@techhat
Copy link
Contributor Author

techhat commented Jul 1, 2015

Sorry @aboe76, don't know why I didn't see this when you first added it.

@aboe76
Copy link
Contributor

aboe76 commented Jul 1, 2015

No problem you have fixed it already, was off course too quick

@techhat techhat mentioned this pull request Jul 7, 2015
Merged
@iggy
Copy link
Contributor

iggy commented Jul 7, 2015

How do dependencies work (document)?

Does this support optional dependencies (like every package manager it mentions in it's influences)?

@techhat
Copy link
Contributor Author

techhat commented Jul 7, 2015

Hi @iggy. At the moment, hard dependencies are enforced (unless --forced), but not resolved. Soft/optional dependencies are not in the design, but an excellent idea.

@techhat
Copy link
Contributor Author

techhat commented Jul 7, 2015

@iggy, ref #25210 and #25211.

This was referenced Sep 12, 2015
Closed
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Awesome Core relates to code central or existential to Salt Tests-Passed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@techhat @cachedout @nmadhok @rallytime @aboe76 @s0undt3ch @iggy @cro @jfindlay