Don't report incorrect line from jinja exception #13416
Merged
+3
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jinja reports the wrong line for UndefinedError exceptions, which results in a misleading comment in the state result. This commit removes the line number and context string from the comment, leaving just the error message telling the user which variable is undefined.
|
Test Failed. If the failures are unrelated to your code, don't stress, a core developer will know these apart. |
thatch45
added a commit
that referenced
this pull request
Jun 12, 2014
Don't report incorrect line from jinja exception
|
Blast! @terminalmage I should not have merged this, it is breaking tests: |
|
Yeah, I should have thought of the tests. I'll take care of them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jinja reports the wrong line for UndefinedError exceptions, which
results in a misleading comment in the state result. This commit removes
the line number and context string from the comment, leaving just the
error message telling the user which variable is undefined.
Resolves #13408.