Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE REQUEST] set max queue size for state runs #63356

Closed
nicholasmhughes opened this issue Dec 21, 2022 · 1 comment · Fixed by #63357
Closed

[FEATURE REQUEST] set max queue size for state runs #63356

nicholasmhughes opened this issue Dec 21, 2022 · 1 comment · Fixed by #63357
Labels
Execution-Module Feature new functionality including changes to functionality and code refactors, etc.

Comments

@nicholasmhughes
Copy link
Collaborator

Is your feature request related to a problem? Please describe.
The queue=True parameter to state module functions allows a new state run to be queued and wait for a run already in progress to complete before proceeding. However, there is currently no limit to how many runs will wait in the queue. If state runs are being performed on an interval and the runs take longer than the interval time, the queue could stack up indefinitely until the machine "falls over".

Describe the solution you'd like
Allow the queue parameter to be set to an integer, which will be checked against the current queue size. If the queue is greater than or equal to maximum, then that specific run will be treated as if queue=False and return a conflict.

Please Note
If this feature request would be considered a substantial change or addition, this should go through a SEP process here https://github.com/saltstack/salt-enhancement-proposals, instead of a feature request.

@nicholasmhughes nicholasmhughes added Feature new functionality including changes to functionality and code refactors, etc. Execution-Module labels Dec 21, 2022
nicholasmhughes added a commit to nicholasmhughes/salt that referenced this issue Dec 21, 2022
@OrangeDog
Copy link
Contributor

If state runs are being performed on an interval then you don't want to be using queue at all. If the previous one is still going, there's no point doing another as soon as it's finished.

Queuing is useful when you're manually running something different.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Execution-Module Feature new functionality including changes to functionality and code refactors, etc.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants