Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

latest windows salt-minion 2014.1.11 reporting jinja error where previous versions did not. #16727

Closed
emmellee opened this issue Oct 17, 2014 · 16 comments
Labels
Bug broken, incorrect, or confusing behavior fixed-pls-verify fix is linked, bug author to confirm fix severity-low 4th level, cosemtic problems, work around exists
Milestone

Comments

@emmellee
Copy link

upgraded to 2014.1.11 from 2014.1.0 and received the following error:

[CRITICAL] Rendering SLS "base:slave" failed: Jinja variable 'dict object' has
o attribute 'TSF'; line 89

---
[...]
    - reload: True
    - require:
      - cmd: Create-{{slaveServiceDisplay}}
      - cmd: Change-{{slaveServiceDisplay}}-Startname
    - watch:
      - file: {{slaveBaseDir}}\jenkins-slave.xml    <======================

---
local:
    Data failed to compile:
----------
    Rendering SLS "base:slave" failed: Jinja variable 'dict object' has no attr
bute 'TSF'; line 89

reverted to 2014.1.1, no error, same (unchanged) content in state file:

{{slaveBaseDir}}\jenkins-slave.xml:
  file:
    - managed
    - template: jinja
    - source: salt://templates/jenkins-slave/jenkins-slave.xml
    - context:
      EXECUTABLE: 'C:\Program Files (x86)\Java\jre7\bin\java.exe'
      BASE: {{slaveBaseDir}}
      SERVICE_NAME: {{slaveServiceName}}
      DISPLAYNAME:  {{slaveServiceDisplay}}
      DESCRIPTION: 'This service runs a slave for Jenkins continuous integration system.'
      TS: {{ pillar['TSF'] }}
      TSPW: {{ pillar['TSP'] }}
      HOSTNAME: {{ pillar['hostname'] }}
      JENKINSURL: {{ pillar['jenkinsurl'] }}
      SLAVESECRET: {{ pillar['slavesecret'] }}
    - require: 
      - file: {{slaveBaseDir}}
@emmellee emmellee changed the title latest salt-minion 2014.1.11 reporting jinja error where previous versions did not. latest windows salt-minion 2014.1.11 reporting jinja error where previous versions did not. Oct 17, 2014
@cachedout
Copy link
Contributor

This may be related to #16656. Can you test against 2014.1.12 please?

@cachedout cachedout added Bug broken, incorrect, or confusing behavior fixed-pls-verify fix is linked, bug author to confirm fix labels Oct 17, 2014
@emmellee
Copy link
Author

Unfortunately I won't be able to do that on my masterless windows minions without a 2012.1.12 windows install executable. I don't have the resources to extract directly from github repo. Will the windows installation page have the 2012.1.12 version available soon?

@emmellee
Copy link
Author

*2014.1.12

@rallytime rallytime added the severity-low 4th level, cosemtic problems, work around exists label Oct 21, 2014
@rallytime
Copy link
Contributor

Thanks for the update @emmellee! We had a regression in 2014.1.11 that affected masterless pillars which was fixed it in 2014.1.12. Unfortunately, there was a problem with salt-cloud in 2014.1.12, so we had to start the testing/packaging process over. 2014.1.13 is forth-coming with the fix for this regression and for salt-cloud as soon as we have the packages ready to go.

@rallytime rallytime added this to the Approved milestone Oct 21, 2014
@rallytime
Copy link
Contributor

@emmellee Have you had a chance to test this on 2014.1.13?

@emmellee
Copy link
Author

emmellee commented Nov 5, 2014

Unfortunately, I see only 2014.1.11 windows installer available...

-----Original Message-----
From: Nicole Thomas [mailto:notifications@github.com]
Sent: Wednesday, November 05, 2014 11:46 AM
To: saltstack/salt
Cc: Eller, Michelle L CIV DISA ESD (US)
Subject: Re: [salt] latest windows salt-minion 2014.1.11 reporting jinja error where previous versions did not. (#16727)

@emmellee https://github.com/emmellee Have you had a chance to test this on 2014.1.13?


Reply to this email directly or view it on GitHub #16727 (comment) . https://github.com/notifications/beacon/AExMH9PHDY0LAQ9LmPTHsQXO8uX1UbiPks5nKlnQgaJpZM4CwGP7.gif

@rallytime
Copy link
Contributor

Oh! Are you checking on the docs? We'll fix that link! In the mean time, you can grab those packages from: http://docs.saltstack.com/downloads/

@rallytime
Copy link
Contributor

@emmellee I've updated the docs with #17216. Those links will show up within the next day or so. Sorry for the confusion there!

@emmellee
Copy link
Author

emmellee commented Nov 6, 2014

Thank you for that link, Nicole. I wasn't aware of it - I've always used http://docs.saltstack.com/en/latest/topics/installation/windows.html

I'll try 2014.1.13 as you suggest...

-----Original Message-----
From: Nicole Thomas [mailto:notifications@github.com]
Sent: Wednesday, November 05, 2014 4:27 PM
To: saltstack/salt
Cc: Eller, Michelle L CIV DISA ESD (US)
Subject: Re: [salt] latest windows salt-minion 2014.1.11 reporting jinja error where previous versions did not. (#16727)

Oh! Are you checking on the docs? We'll fix that link! In the mean time, you can grab those packages from: http://docs.saltstack.com/downloads/


Reply to this email directly or view it on GitHub #16727 (comment) . https://github.com/notifications/beacon/AExMH6ZBJykX9z20ubb4EQkNxFrRY7_Kks5nKpu6gaJpZM4CwGP7.gif

@rallytime
Copy link
Contributor

No problem! Let us know what you find out!

@rallytime
Copy link
Contributor

Oh, there are also 2014.7.0 windows packages available at that link as well, if you wanted to try that one instead.

@rallytime
Copy link
Contributor

@emmellee just a bump here. Were you able to try a newer version?

@emmellee
Copy link
Author

I tried installing 2014.7.0 and ran into issue number 19666

@emmellee
Copy link
Author

i also tried 2014.1.13 which also unpacked files to the root of my D: drive. I've uninstalled both, deleted the files, and reverted to 2014.1.1 which does not unpack files to the root of my D: drive.

@rallytime
Copy link
Contributor

@emmellee Ah, sorry I did not see your latest comments here. We're currently on release 2014.7.2 now - any chance you've given that a try yet? The releases on the 2014.7 branch have been MUCH more stable than the 2014.1 releases.

@rallytime
Copy link
Contributor

I am going to close this since we haven't heard back. If this remains a problem on newer releases, please leave a comment and we will be glad to give this another go.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug broken, incorrect, or confusing behavior fixed-pls-verify fix is linked, bug author to confirm fix severity-low 4th level, cosemtic problems, work around exists
Projects
None yet
Development

No branches or pull requests

3 participants