Skip to content
This repository has been archived by the owner on Jan 24, 2024. It is now read-only.

SEP 33: Re-adding point zero to major Salt versions - process update #49

Merged
merged 6 commits into from
Aug 19, 2021

Conversation

sagetherage
Copy link
Contributor

@sagetherage sagetherage commented Jun 1, 2021

Adding a draft SEP to re-add the point zero to major Salt versions as a standard operating procedure or to the process.

  • Intent is not to adjust the past, but to explicitly state the process going forward and why
  • Specific tasks and adjustments will need to be made, this is to discuss, plan, and create the premise to implement; meaning we agree the process and standard should be in the format of ####.# example: 3005.0 and once approved the date at which this will become the standard will be announced/communicated

@sagetherage sagetherage added the Draft Initial Status label Jun 1, 2021
@sagetherage sagetherage requested a review from a team as a code owner June 1, 2021 22:52
@sagetherage sagetherage requested review from joechainz and removed request for a team June 1, 2021 22:52
@welcome
Copy link

welcome bot commented Jun 1, 2021

Hello! Thank you for submitting a Salt Enhancement Proposal! Our process is detailed in the README.md and more about the SEP Life-cycle. An Open Core Team member will be assigned to follow up and help guide this SEP soon and you will find the this in the Community Slack channel #sep.
Please be sure to review our Code of Conduct.
You can also check out some of our community
resources:
- Community Wiki
- Salt’s Contributor Guide
- Join our Community Slack
- IRC on Freenode
- SaltStack YouTube channel
- SaltStackInc Twitch channel

@sagetherage sagetherage changed the title Adding draft SEP for point zero to major versions SEP:33 Re-adding point zero to major Salt versions Jun 1, 2021
@sagetherage sagetherage self-assigned this Jun 1, 2021
@max-arnold
Copy link

👍

salt-bootstrap needs to be fixed as well, to handle pinning to major versions. Some time ago I added a kludge for that: saltstack/salt-bootstrap#1491

@sagetherage sagetherage changed the title SEP:33 Re-adding point zero to major Salt versions SEP 33: Re-adding point zero to major Salt versions Jun 3, 2021
@OrangeDog
Copy link

It's unclear. Are you proposing to go back and re-release e.g. 3000 as 3000.0?

If so, this could be even more disruptive. Un-releasing 3000 isn't really possible, and I'm sure there's at least one system that will treat 3000 and 3000.0 as different. More in-depth impact analysis is required.

If not, then it just makes things even more inconsistent. You can't put the genies of bad decisions back in the bottle once you've released them.

@sagetherage
Copy link
Contributor Author

I didn't intent to go back and update already released versions; however, if there is a reason to re-release I would be willing to discuss, but I did write it as to suggest as such. I can adjust.

The intent of this proposal is add it back in as part of the process or standard operating procedure and to detail the decision going forward to include the point zero specifically because without it we have deviated from it and it causes many problems. I can include more details in the SEP.

updated language to answer the TBD question of re-releasing - at this time we do not see a benefit
@sagetherage sagetherage changed the title SEP 33: Re-adding point zero to major Salt versions SEP 33: Re-adding point zero to major Salt versions - process update Jun 22, 2021
@sagetherage sagetherage added the Final Comment Period Speak now or forever hold your peace. label Jun 29, 2021
@sagetherage sagetherage removed the Draft Initial Status label Jun 29, 2021
@sagetherage sagetherage added Accepted and removed Final Comment Period Speak now or forever hold your peace. labels Aug 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants