-
Notifications
You must be signed in to change notification settings - Fork 551
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(freebsd): update packages from py37-*
=> py38-*
#1574
Conversation
- py3-git-3000-freebsd-130 | ||
- py3-git-3000-freebsd-122 | ||
# - py3-git-3000-freebsd-130 | ||
# - py3-git-3000-freebsd-122 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Before submitting this PR, I ran the tests in my fork and these two jobs were failing, so I disabled them for the time being:
Perhaps someone will be able to get them working again eventually. Or maybe it doesn't even matter that much since 3000.x
is EOL at the end of next month.
@krionbsd Any thoughts?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have to exclude 3000 from CI anyway, FreeBSD merged Python 3.8 to 12.2 as default python version, and I failed to use it with salt 3000
/usr/local/sbin/pkg install -y py37-requests || return 1 | ||
/usr/local/sbin/pkg install -y py37-tornado4 || return 1 | ||
/usr/local/sbin/pkg install -y py38-requests || return 1 | ||
/usr/local/sbin/pkg install -y py38-tornado4 || return 1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When searching for the packages, I found other options available here:
# pkg search py38-tornado
py38-tornado-6.1 Python Web Server from FriendFeed
py38-tornado4-4.5.3 Python Web Server from FriendFeed
py38-tornado5-5.1.1 Python Web Server from FriendFeed
Can/should this be updated to use py38-tornado5
instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a bit more than that, we've to s/py37/py38 globally, I'd run it with tornado4 for the future
Re-enable once the pre-salted Vagrant boxes have been updated with the `py38-*`-based Salt packages. See: * saltstack/salt-bootstrap#1574
What does this PR do?
Noticed the FreeBSD jobs failing when submitting #1573. This PR updates the FreeBSD packages installed by the bootstrap to the
py38-*
versions.