Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added HostInterface and HostInterfaceItem to config #155

Merged
merged 1 commit into from
Oct 19, 2021
Merged

Added HostInterface and HostInterfaceItem to config #155

merged 1 commit into from
Oct 19, 2021

Conversation

waynegemmell
Copy link
Contributor

PR progress checklist (to be filled in by reviewers)

  • Changes to documentation are appropriate (or tick if not required)
  • Changes to tests are appropriate (or tick if not required)
  • Reviews completed

What type of PR is this?

Primary type

  • [build] Changes related to the build system
  • [chore] Changes to the build process or auxiliary tools and libraries such as documentation generation
  • [ci] Changes to the continuous integration configuration
  • [feat] A new feature
  • [fix] A bug fix
  • [perf] A code change that improves performance
  • [refactor] A code change that neither fixes a bug nor adds a feature
  • [revert] A change used to revert a previous commit
  • [style] Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.)

Does this PR introduce a BREAKING CHANGE?

No.

Related issues and/or pull requests

None

Describe the changes you're proposing

My change is a config update. I added HostInterface and HostInterfaceItem to the configuration for the Zabbix Agent.
This allows agents to register with the server using their fqdn rather than the IP address. In a cloud environment this is vital because of the mess caused by IP address reuse.

I also added the architecture to the Ubuntu repository because that was playing up.

Copy link
Collaborator

@hatifnatt hatifnatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@waynegemmell thanks for contribution, sorry for delay with review.
Please check failed jobs in pipeline. Particularly you need to fix your commit messages, more about it here https://github.com/saltstack-formulas/.github/blob/master/CONTRIBUTING.rst

@waynegemmell
Copy link
Contributor Author

I don't understand scope as mentioned in the document mentioned above. I hope this was correct.

@hatifnatt
Copy link
Collaborator

Yes you get an idea about scope. But can you please rebase and squash all your commits into one, and give it message like
feat(agent): add HostInterface and HostInterfaceItem to config of course you need to force push then.

@hatifnatt
Copy link
Collaborator

@waynegemmell it doesn't look squashed to me, there is still 6 commits, and in commit d19c875 you actually bring back empty line which was gone in 2724c75
Also your previous commit messages was better, you don't need to put whole description inside braces, scope must be something short i.e. agent, server, pillar.example, etc. you can use my suggestion from previous message - feat(agent): add HostInterface and HostInterfaceItem to config

@waynegemmell
Copy link
Contributor Author

Well that took forever to work through. I think it's finally ok.

Copy link
Collaborator

@hatifnatt hatifnatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more force push and it's ready to merge :)

@hatifnatt hatifnatt merged commit 04a7d1f into saltstack-formulas:master Oct 19, 2021
@saltstack-formulas-travis

🎉 This PR is included in version 1.3.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@hatifnatt
Copy link
Collaborator

hatifnatt commented Oct 19, 2021

@waynegemmell thanks for the all effort you put in to made these changes merged :)

@waynegemmell
Copy link
Contributor Author

Thanks for the patience in this. I learned a lot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants