-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added HostInterface and HostInterfaceItem to config #155
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@waynegemmell thanks for contribution, sorry for delay with review.
Please check failed jobs in pipeline. Particularly you need to fix your commit messages, more about it here https://github.com/saltstack-formulas/.github/blob/master/CONTRIBUTING.rst
I don't understand scope as mentioned in the document mentioned above. I hope this was correct. |
Yes you get an idea about scope. But can you please rebase and squash all your commits into one, and give it message like |
@waynegemmell it doesn't look squashed to me, there is still 6 commits, and in commit d19c875 you actually bring back empty line which was gone in 2724c75 |
Well that took forever to work through. I think it's finally ok. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One more force push and it's ready to merge :)
🎉 This PR is included in version 1.3.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
@waynegemmell thanks for the all effort you put in to made these changes merged :) |
Thanks for the patience in this. I learned a lot. |
PR progress checklist (to be filled in by reviewers)
What type of PR is this?
Primary type
[build]
Changes related to the build system[chore]
Changes to the build process or auxiliary tools and libraries such as documentation generation[ci]
Changes to the continuous integration configuration[feat]
A new feature[fix]
A bug fix[perf]
A code change that improves performance[refactor]
A code change that neither fixes a bug nor adds a feature[revert]
A change used to revert a previous commit[style]
Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.)Does this PR introduce a
BREAKING CHANGE
?No.
Related issues and/or pull requests
None
Describe the changes you're proposing
My change is a config update. I added HostInterface and HostInterfaceItem to the configuration for the Zabbix Agent.
This allows agents to register with the server using their fqdn rather than the IP address. In a cloud environment this is vital because of the mess caused by IP address reuse.
I also added the architecture to the Ubuntu repository because that was playing up.