Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add journald #60

Merged
merged 2 commits into from
Sep 19, 2020
Merged

Add journald #60

merged 2 commits into from
Sep 19, 2020

Conversation

javierbertoli
Copy link
Member

PR progress checklist (to be filled in by reviewers)

  • Changes to documentation are appropriate (or tick if not required)
  • Changes to tests are appropriate (or tick if not required)
  • Reviews completed

What type of PR is this?

Primary type

  • [build] Changes related to the build system
  • [chore] Changes to the build process or auxiliary tools and libraries such as documentation generation
  • [ci] Changes to the continuous integration configuration
  • [feat] A new feature
  • [fix] A bug fix
  • [perf] A code change that improves performance
  • [refactor] A code change that neither fixes a bug nor adds a feature
  • [revert] A change used to revert a previous commit
  • [style] Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.)

Secondary type

  • [docs] Documentation changes
  • [test] Adding missing or correcting existing tests

Does this PR introduce a BREAKING CHANGE?

No.

Related issues and/or pull requests

Describe the changes you're proposing

This PR adds a state to manage journald configuration

Pillar / config required to test the proposed changes

Debug log showing how the proposed changes work

Documentation checklist

  • Updated the README (e.g. Available states).
  • Updated pillar.example.

Testing checklist

  • Included in Kitchen (i.e. under state_top).
  • Covered by new/existing tests (e.g. InSpec, Serverspec, etc.).
  • Updated the relevant test pillar.

Additional context

@javierbertoli javierbertoli requested a review from a team as a code owner September 15, 2020 22:49
@pull-assistant
Copy link

pull-assistant bot commented Sep 15, 2020

Score: 1.00

Best reviewed: commit by commit


Optimal code review plan

     fix(resolved): add missing header in config file

     feat(journald): add service management

Powered by Pull Assistant. Last update ffa0d89 ... 32d2e70. Read the comment docs.

@javierbertoli
Copy link
Member Author

@myii failures are not related to the PR nor the formula. Do you think we can merge?

@myii myii merged commit 2f72b3f into saltstack-formulas:master Sep 19, 2020
@myii
Copy link
Member

myii commented Sep 19, 2020

Thanks, @javierbertoli -- merged. Appreciate the review, @n-rodriguez.

I wanted to push the new tiamat pre-salted images here but didn't have the permissions. Here's the proposed build:

I've had to remove default-opensuse-leap-152-master-py3 because it's now failing but I don't have the time to dig further:

@saltstack-formulas-travis

🎉 This PR is included in version 0.17.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@myii
Copy link
Member

myii commented Sep 20, 2020

Updated CI to use Tiamat pre-salted images: 580d3b9.

@javierbertoli javierbertoli deleted the add_journald branch November 24, 2020 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants