-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade formula to new standards #23
Conversation
Just a quick note for now: we've got the updated matrix running in Cirrus (see |
Do we need to keep cirrus on this formula? |
@n-rodriguez It's not absolutely necessary but I was hoping to keep at least some of the repos active on Cirrus, so that we can keep working towards long-term CI solutions (inc. sharing the load with Travis, working out if we can get FreeBSD and Windows working, etc.). There are only two repos using Cirrus at the moment: |
done
I'm fine with it 👍 |
@n-rodriguez OK, we should be able to get https://cirrus-ci.com/task/4842608959946752?command=verify#L353-L357: errors:
- Running scope as unit run-300.scope.
Loaded plugins: ovl, priorities
No package syslog-ng available.
Error: Nothing to do |
@n-rodriguez Good news, with the changes I've tested, this is working across all 28 of our instances now (including
One nice thing about Cirrus is that it runs around 8 instances concurrently, so it can finish pretty fast at good times. I'm going to clean up the commits and then add them here, for your perusal before merging. |
@n-rodriguez So I've added 3 commits to this PR: 4e46ea0 -- feat(install): provide EPEL repo configuration for
|
@n-rodriguez Right, since the https://travis-ci.com/saltstack-formulas/syslog-ng-formula/builds/129135816#L210-L217: $ yamllint -s .
./test/salt/pillar/syslog_ng.sls
4:24 warning truthy value should be one of [false, true] (truthy)
6:16 warning truthy value should be one of [false, true] (truthy)
7:17 warning truthy value should be one of [false, true] (truthy)
16:7 error wrong indentation: expected 8 but found 6 (indentation)
20:7 error wrong indentation: expected 8 but found 6 (indentation)
25:7 error wrong indentation: expected 8 but found 6 (indentation) I'll just append another commit to fix that. |
https://travis-ci.com/saltstack-formulas/syslog-ng-formula/builds/129135816#L210-L217: ```bash $ yamllint -s . ./test/salt/pillar/syslog_ng.sls 4:24 warning truthy value should be one of [false, true] (truthy) 6:16 warning truthy value should be one of [false, true] (truthy) 7:17 warning truthy value should be one of [false, true] (truthy) 16:7 error wrong indentation: expected 8 but found 6 (indentation) 20:7 error wrong indentation: expected 8 but found 6 (indentation) 25:7 error wrong indentation: expected 8 but found 6 (indentation) ```
@myii do you think we can merge it? |
@n-rodriguez Sure, I just wanted you to review the commits I added. Merged. |
Thank you! |
🎉 This PR is included in version 0.4.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
No description provided.