-
Notifications
You must be signed in to change notification settings - Fork 419
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: enable Vagrant-based testing using GitHub Actions #502
ci: enable Vagrant-based testing using GitHub Actions #502
Conversation
* Semi-automated using myii/ssf-formula#304
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe homogenize the use of system.platform
over platform
?
de6727a
to
e6bcdc1
Compare
Self-merge since mostly CI, tests and docs. Other minor changes don't affect other platforms other than the new ones introduced here. Thanks for the review, @baby-gnu! |
🎉 This PR is included in version 1.8.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
PR progress checklist (to be filled in by reviewers)
What type of PR is this?
Primary type
[build]
Changes related to the build system[chore]
Changes to the build process or auxiliary tools and libraries such as documentation generation[ci]
Changes to the continuous integration configuration[feat]
A new feature[fix]
A bug fix[perf]
A code change that improves performance[refactor]
A code change that neither fixes a bug nor adds a feature[revert]
A change used to revert a previous commit[style]
Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.)Secondary type
[docs]
Documentation changes[test]
Adding missing or correcting existing testsDoes this PR introduce a
BREAKING CHANGE
?No.
Related issues and/or pull requests
Describe the changes you're proposing
Explaining commit-by-commit:
ci: enable Vagrant-based testing using GitHub Actions
docs(readme): add
Testing with Vagrant
sectionfix(osfamilymap): use
whoami
for Windowsrootuser
test: add Windows map verification files
map.jinja
verification files for all Windows platforms.test(_mapdata): add Arch Linux verification file
map.jinja
verification files for Arch Linux.refactor(retry_options): provide options from defaults/pillar
retry_options
as done in many other formulas.fix(freebsd): update to provide support for most recent versions
osmap.yaml
.map.jinja
verification files for FreeBSD.fix(openbsd): update to provide support for most recent versions
osmap.yaml
.map.jinja
verification files for OpenBSD.test: update for new platforms (inc. using
system
library)system
library throughout.Pillar / config required to test the proposed changes
As-is.
Debug log showing how the proposed changes work
As shown in the CI.
Documentation checklist
README
(e.g.Available states
).pillar.example
.Testing checklist
state_top
).Additional context