Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed pillar example formatting for Slack #345

Merged
merged 1 commit into from
Dec 23, 2017

Conversation

Angelo-Verona
Copy link
Contributor

Changed formatting in the example for a pillar to avoid warning about wrong dictionary/list format from Salt. Added a comment about the type of token.

…ionary format from Salt. Added comment about type of token.
@0xf10e
Copy link
Contributor

0xf10e commented Dec 8, 2017

I would move the comment above the token but otherwise it looks fine to me.
(Though I got to admit all those lines being changed just by addind the two spaces annoys me ^^"")

Copy link
Member

@aboe76 aboe76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't mind the comment behind the token,
looks good to me.

@Angelo-Verona
Copy link
Contributor Author

I know, but the formatting throws error nonetheless. And for space-saving, I added comment behind the token. You still need to delete that dummy token what is there, so you can delete until end of the line in one step, the extra line for comment would mean that you need to delete hint above for clean config and also the dummy token.

@aboe76 aboe76 merged commit d01083f into saltstack-formulas:master Dec 23, 2017
@aboe76
Copy link
Member

aboe76 commented Dec 23, 2017

@Angelo-Verona thanks for this addition.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants