add a way to set which release of saltstack to use #314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SaltStack provides "versioned" repositories, this commit add a way to set which release of salt to use. It adds a pillar "salt:release" which can be set to a specific release (ex: 2016.11). This release is then used to configure properly the repositories URLs for Debian/Ubuntu/RedHat. The default behavior is to point to 'latest', retaining the previous behavior if the "salt:release" pillar is not set.
|
Please note that this PR is not fully tested. |
|
@kakwa I will test this tomorrow, I have a few machines to test the different configurations |
|
I got the following error on Debian based systems: [CRITICAL] Rendering SLS 'base:salt.minion' failed: Jinja syntax error: expected token ',', got 'string' because of the missing trailing comma's in the redhat portion It should be: |
aboe76
reviewed
May 31, 2017
salt/map.jinja
Outdated
| @@ -61,6 +62,8 @@ that differ from whats in defaults.yaml | |||
| }, | |||
| }, | |||
| 'RedHat': { | |||
| 'pkgrepo': 'https://repo.saltstack.com/yum/redhat/$releasever/$basearch/' + salt_release | |||
aboe76
reviewed
May 31, 2017
salt/map.jinja
Outdated
| @@ -61,6 +62,8 @@ that differ from whats in defaults.yaml | |||
| }, | |||
| }, | |||
| 'RedHat': { | |||
| 'pkgrepo': 'https://repo.saltstack.com/yum/redhat/$releasever/$basearch/' + salt_release | |||
| 'key_url': 'https://repo.saltstack.com/yum/redhat/$releasever/$basearch/' + salt_release + '/SALTSTACK-GPG-KEY.pub' | |||
There was a problem hiding this comment.
youps, sorry for that
add missing comas
|
Thanks @kakwa |
19 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SaltStack provides "versioned" repositories, this commit add a way
to set which release of salt to use.
It adds a pillar "salt:release" which can be set to a specific release
(ex: 2016.11). This release is then used to configure properly the
repositories URLs for Debian/Ubuntu/RedHat.
The default behavior is to point to 'latest', retaining the previous
behavior if the "salt:release" pillar is not set.
Related to #293