Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mine_functions section to minion config #28

Closed
wants to merge 3 commits into from

Conversation

tmandry
Copy link

@tmandry tmandry commented Mar 11, 2014

See http://docs.saltstack.com/topics/mine/ for details.

I needed this in order to use the hostsfile-formula.

@wwentland
Copy link
Contributor

It would be great if you, @tmandry, could add an example of this functionality to pillar.example.

Can you think of a way to allow for support of mine function aliases in the future (or now) in such a way that existing pillars remain backwards compatible? If you can it would be great if this PR could be updated accordingly as it would be a shame if we have to introduce backward incompatible changes once Helium has been released in order to support that functionality.

@jcftang
Copy link
Member

jcftang commented Jan 15, 2015

@nmadhok given that #91 got reverted due to my mistake, is there a possibility of getting this merged? is there something fundamentally broken with this PR?

@iggy
Copy link
Contributor

iggy commented Jan 15, 2015

A. It contains merge conflicts
B. You are putting something in a pillar to then have it loaded into a config file when it can be read from the pillar to begin with

@nmadhok
Copy link
Member

nmadhok commented Jan 16, 2015

@jcftang Like @iggy mentioned in a comment above, this PR contains merge conflicts and you need to resolve the merge conflicts first so I can consider it further.

@jcftang
Copy link
Member

jcftang commented Jan 16, 2015

Ok, it feels like it's better to note to the user it is better to put this config into the minion pillar first before trying to resolve the conflict. I'm adding a link here to the documentation -- http://docs.saltstack.com/en/latest/topics/mine/#mine-functions

@aboe76
Copy link
Member

aboe76 commented Feb 19, 2015

Only thing that can be set only in the minion config is the mine interval
the mine_interval must be set in the minion’s runtime config.
The configuration option is ignored in grains or pillar data.

@nmadhok nmadhok closed this Feb 20, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants