-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: implement test using Kitchen and Inspec, and CI with Travis #52
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great PR, @daks. For the first part of the review, there's just some files which need to be added direct from the template-formula
:
.rubocop.yml
.salt-lint
.yamllint
release-rules.js
And one that needs to be removed:
docs/CONTRIBUTING_DOCS.rst
With these done, only yamllint
errors need to be resolved:
rabbitmq-formula$ yamllint -s .
./pillar.example
1:1 warning missing document start "---" (document-start)
2:1 warning comment not indented like content (comments-indentation)
3:12 warning truthy value should be one of [false, true] (truthy)
4:12 warning truthy value should be one of [false, true] (truthy)
18:16 warning truthy value should be one of [false, true] (truthy)
21:9 error wrong indentation: expected 10 but found 8 (indentation)
22:11 error wrong indentation: expected 12 but found 10 (indentation)
28:16 warning truthy value should be one of [false, true] (truthy)
31:9 error wrong indentation: expected 10 but found 8 (indentation)
32:11 error wrong indentation: expected 12 but found 10 (indentation)
47:8 warning missing starting space in comment (comments)
50:1 error syntax error: could not find expected ':'
After that, it's just a matter of arranging the platforms for testing, with some changes to kitchen.yml
(for the new platforms that are supported) and .travis.yml
. These are pretty good examples to base that upon:
2efc614
to
8a09a13
Compare
@myii I added missing files, fixed lint errors, but I'm not sure what to do with the testing matrix, I already took the one from |
804232e
to
00d1974
Compare
00d1974
to
e9eb8ff
Compare
@myii I updated files from Feel free to comment if needed, or merge it, as I think it's OK now. |
@daks I'll have a look at this within the next day. If there are only minor issues (such as Actually, since the new pre-salted images are effectively available now, I'll probably include those in the commit as well. |
Thanks for the confirmation on Slack, @daks -- merged. |
🎉 This PR is included in version 0.15.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
What type of PR is this?
Implement semantic-release and a limited set of Kitchen/Inspec tests on some platforms.
Primary type
[build]
Changes related to the build system[chore]
Changes to the build process or auxiliary tools and libraries such as documentation generation[ci]
Changes to the continuous integration configuration[feat]
A new feature[fix]
A bug fix[perf]
A code change that improves performance[refactor]
A code change that neither fixes a bug nor adds a feature[revert]
A change used to revert a previous commit[style]
Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.)Secondary type
[docs]
Documentation changes[test]
Adding missing or correcting existing testsDoes this PR introduce a
BREAKING CHANGE
?No.
Related issues and/or pull requests
Describe the changes you're proposing
Pillar / config required to test the proposed changes
Debug log showing how the proposed changes work
Documentation checklist
README
(e.g.Available states
).pillar.example
.Testing checklist
state_top
).Additional context
Formula working on a limited set of platforms. First version of semantic-release implementation. Tests pass on working platforms.