Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove seen file before update pam #4

Merged
merged 1 commit into from Aug 21, 2018
Merged

Remove seen file before update pam #4

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions pam/update.sls
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,10 @@

{% if grains.os_family == 'Debian' %}
pam-auth-update:
module.run:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is difference or benefit of using module.run.file.remove over salt.states.file.absent. I never use module.run so just wondering?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you are correct, salt.states.file.absent is better.
When I searched how remove a file on salt I saw the module.run method so I used it.

If you feel that file.absent is better you may change it (my salt knowledge is very limited).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it works, then its fine. thanks.

- name: file.remove
- path: /var/lib/pam/seen

cmd.run:
- name: DEBIAN_FRONTEND=noninteractive pam-auth-update --force
{% endif %}
Expand Down