Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(config): update libvirtd.conf jinja template to version 5.8.0 #65

Merged
merged 1 commit into from
Nov 4, 2019

Conversation

aboe76
Copy link
Member

@aboe76 aboe76 commented Nov 2, 2019

PR progress checklist (to be filled in by reviewers)

  • Changes to documentation are appropriate (or tick if not required)
  • Changes to tests are appropriate (or tick if not required)
  • Reviews completed

What type of PR is this?

Primary type

  • [build] Changes related to the build system
  • [chore] Changes to the build process or auxiliary tools and libraries such as documentation generation
  • [ci] Changes to the continuous integration configuration
  • [feat] A new feature
  • [fix] A bug fix
  • [perf] A code change that improves performance
  • [refactor] A code change that neither fixes a bug nor adds a feature
  • [revert] A change used to revert a previous commit
  • [style] Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.)

Secondary type

  • [docs] Documentation changes
  • [test] Adding missing or correcting existing tests

Does this PR introduce a BREAKING CHANGE?

No.

Related issues and/or pull requests

No

Describe the changes you're proposing

Update the default libvirtd.conf to libvirt version 5.8.0

Pillar / config required to test the proposed changes

Debug log showing how the proposed changes work

Documentation checklist

  • Updated the README (e.g. Available states).
  • Updated pillar.example.

Testing checklist

  • Included in Kitchen (i.e. under state_top).
  • Covered by new/existing tests (e.g. InSpec, Serverspec, etc.).
  • Updated the relevant test pillar.

Additional context

@aboe76 aboe76 requested a review from myii November 2, 2019 13:55
@myii
Copy link
Member

myii commented Nov 2, 2019

Nice PR, @aboe76. Do you mind if we request a review from @baby-gnu? Daniel has put in a lot of work on this formula and I reckon would be the best placed to review this.

@myii myii requested a review from baby-gnu November 2, 2019 13:58
@aboe76
Copy link
Member Author

aboe76 commented Nov 2, 2019

No problem

Copy link
Contributor

@baby-gnu baby-gnu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update.

@myii myii merged commit cf8c88b into saltstack-formulas:master Nov 4, 2019
@myii
Copy link
Member

myii commented Nov 4, 2019

Thanks for the review, @baby-gnu. Merged it @aboe76.

@saltstack-formulas-travis

🎉 This PR is included in version 3.3.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants