Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(requisits): Improve configuration files dependencies #57

Merged

Conversation

baby-gnu
Copy link
Contributor

@baby-gnu baby-gnu commented Sep 5, 2019

  • explicit package requisit

  • libvirtd configuration changes must restart the service

Including the package SLS orders it before the current SLS but we want
to be more explicit about it.

* libvirt/server/config/files.sls: require
  “libvirt-server-package-install-pkg-installed” for both configuration
  files.
* libvirt/server/config/files.sls: make sure the service watch the
  “libvirtd.conf” file.
@baby-gnu baby-gnu requested a review from aboe76 September 5, 2019 12:15
@aboe76
Copy link
Member

aboe76 commented Sep 5, 2019

@baby-gnu can you change to commit for semantic release?

@baby-gnu
Copy link
Contributor Author

baby-gnu commented Sep 6, 2019

@aboe76 I'm not sure to understand, you speak about the PR title?

@aboe76
Copy link
Member

aboe76 commented Sep 7, 2019

@baby-gnu yes

@aboe76 aboe76 changed the title Improve configuration files dependencies feat(requisits): Improve configuration files dependencies Sep 8, 2019
@aboe76 aboe76 merged commit efaa5f0 into saltstack-formulas:master Sep 8, 2019
@saltstack-formulas-travis

🎉 This PR is included in version 3.1.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@baby-gnu baby-gnu deleted the bugfix/config-files-dependencies branch September 9, 2019 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants