feat(formula): align with template formula; add ci tests #5

noelmcloughlin · 2020-04-21T21:50:39Z

PR progress checklist (to be filled in by reviewers)

Changes to documentation are appropriate (or tick if not required)
Changes to tests are appropriate (or tick if not required)
Reviews completed

What type of PR is this?

Primary type

[build] Changes related to the build system
[chore] Changes to the build process or auxiliary tools and libraries such as documentation generation
[ci] Changes to the continuous integration configuration
[feat] A new feature
[fix] A bug fix
[perf] A code change that improves performance
[refactor] A code change that neither fixes a bug nor adds a feature
[revert] A change used to revert a previous commit
[style] Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.)

Secondary type

[docs] Documentation changes
[test] Adding missing or correcting existing tests

Does this PR introduce a `BREAKING CHANGE`?

YES

Related issues and/or pull requests

Describe the changes you're proposing

Following Intellij blueprint, align this formula to template formula and add ci tests

Pillar / config required to test the proposed changes

Debug log showing how the proposed changes work

Documentation checklist

Updated the README (e.g. Available states).
Updated pillar.example.

Testing checklist

Included in Kitchen (i.e. under state_top).
Covered by new/existing tests (e.g. InSpec, Serverspec, etc.).
Updated the relevant test pillar.

Additional context

noelmcloughlin · 2020-04-21T21:51:44Z

MacOS trace

local:
----------
          ID: rider-macos-app-clean-files
    Function: file.absent
        Name: /tmp/jetbrains/rider
      Result: True
     Comment: File /tmp/jetbrains/rider is not present
     Started: 22:09:34.458670
    Duration: 0.881 ms
     Changes:   
----------
          ID: rider-macos-app-clean-files
    Function: file.absent
        Name: /Applications/Rider.app
      Result: True
     Comment: File /Applications/Rider.app is not present
     Started: 22:09:34.459731
    Duration: 0.401 ms
     Changes:   
----------
          ID: rider-config-clean-file-absent
    Function: file.absent
        Name: /tmp/dummy_list_item
      Result: True
     Comment: File /tmp/dummy_list_item is not present
     Started: 22:09:34.460349
    Duration: 0.383 ms
     Changes:   
----------
          ID: rider-config-clean-file-absent
    Function: file.absent
        Name: /etc/defaults/rider.sh
      Result: True
     Comment: File /etc/defaults/rider.sh is not present
     Started: 22:09:34.460926
    Duration: 0.386 ms
     Changes:   
----------
          ID: rider-config-clean-file-absent
    Function: file.absent
        Name: /Users/nmcloughlin/Desktop/Rider
      Result: True
     Comment: File /Users/nmcloughlin/Desktop/Rider is not present
     Started: 22:09:34.461513
    Duration: 0.407 ms
     Changes:   
----------
          ID: rider-macos-app-install-curl
    Function: file.directory
        Name: /tmp/jetbrains/rider
      Result: True
     Comment: Directory /tmp/jetbrains/rider updated
     Started: 22:09:34.462043
    Duration: 11.512 ms
     Changes:   
              ----------
              /tmp/jetbrains/rider:
                  New Dir
----------
          ID: rider-macos-app-install-curl
    Function: pkg.installed
        Name: curl
      Result: True
     Comment: All specified packages are already installed
     Started: 22:09:38.731563
    Duration: 11321.222 ms
     Changes:   
----------
          ID: rider-macos-app-install-curl
    Function: cmd.run
        Name: curl -Lo /tmp/jetbrains/rider/rider-2020.1 https://download.jetbrains.com/rider/JetBrains.Rider-2020.1.0.dmg
      Result: True
     Comment: Command "curl -Lo /tmp/jetbrains/rider/rider-2020.1 https://download.jetbrains.com/rider/JetBrains.Rider-2020.1.0.dmg" run
     Started: 22:09:50.056084
    Duration: 1758931.912 ms
     Changes:   
              ----------
              pid:
                  69411
              retcode:
                  0
              stderr:
                    % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                                   Dload  Upload   Total   Spent    Left  Speed
                  
                    0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
                  100   138  100   138    0     0    259      0 --:--:-- --:--:-- --:--:--   259
                  
                    0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
                    0  755M    0  223k    0     0   115k      0  1:51:13  0:00:01  1:51:12  237k
                    0  755M    0  655k    0     0   224k      0  0:57:31  0:00:02  0:57:29  338k
   <CUT>
                   99  755M   99  754M    0     0   439k      0  0:29:19  0:29:17  0:00:02  863k
                  100  755M  100  755M    0     0   439k      0  0:29:18  0:29:18 --:--:--  832k
              stdout:
----------
          ID: rider-macos-app-install-checksum
    Function: module.run
        Name: file.check_hash
      Result: True
     Comment: onlyif condition is false
     Started: 22:39:08.989782
    Duration: 763.973 ms
     Changes:   
----------
          ID: rider-macos-app-install-checksum
    Function: file.absent
        Name: /tmp/jetbrains/rider/rider-2020.1
      Result: True
     Comment: State was not run because onfail req did not change
     Started: 22:39:09.754474
    Duration: 0.003 ms
     Changes:   
----------
          ID: rider-macos-app-install-macpackage
    Function: macpackage.installed
        Name: /tmp/jetbrains/rider/rider-2020.1
      Result: True
     Comment: Rider.app installed
     Started: 22:39:09.754688
    Duration: 55313.03 ms
     Changes:   
              ----------
              installed:
                  - Rider.app
----------
          ID: rider-macos-app-install-macpackage
    Function: file.managed
        Name: /tmp/mac_shortcut.sh
      Result: True
     Comment: File /tmp/mac_shortcut.sh updated
     Started: 22:40:05.068039
    Duration: 79.291 ms
     Changes:   
              ----------
              diff:
                  --- 
                  +++ 
                  @@ -1,5 +1,5 @@
                   #!/usr/bin/env bash
                   
                  -Source="/Applications/Webstorm.app"
                  +Source="/Applications/Rider.app"
                   Destination="/Users/nmcloughlin/Desktop"
                   /usr/bin/osascript -e "tell application \"Finder\" to make alias file to POSIX file \"$Source\" at POSIX file \"$Destination\""
----------
          ID: rider-macos-app-install-macpackage
    Function: cmd.run
        Name: /tmp/mac_shortcut.sh
      Result: True
     Comment: Command "/tmp/mac_shortcut.sh" run
     Started: 22:40:05.148193
    Duration: 1976.757 ms
     Changes:   
              ----------
              pid:
                  72673
              retcode:
                  0
              stderr:
              stdout:
                  alias file Rider of folder Desktop of folder nmcloughlin of folder Users of startup disk
----------
          ID: rider-config-file-file-managed-environ_file
    Function: file.managed
        Name: /etc/defaults/rider.sh
      Result: True
     Comment: File /etc/defaults/rider.sh updated
     Started: 22:40:07.125607
    Duration: 1869.634 ms
     Changes:   
              ----------
              diff:
                  New file
              group:
                  nmcloughlin
              mode:
                  0644
              user:
                  nmcloughlin

Summary for local
-------------
Succeeded: 14 (changed=6)

BREAKING CHANGE: Major refactor of formula to bring it in alignment with the template-formula. As with all substantial changes, please ensure your existing configurations work in the ways you expect from this formula.

…rmula into refactor

…ins-rider-formula into refactor

pull-assistant · 2020-05-06T19:56:55Z

Best reviewed: commit by commit

Optimal code review plan (1 warning)

feat(formula): align to template-formula; add ci

pillar.example 60% changes removed in feat(formula): align...

rider/init.sls 53% changes removed in feat(formula): align...

FORMULA 88% changes removed in feat(formula): align...

rider/map.jinja 83% changes removed in feat(formula): align...

feat(formula): align to template-formula; add ci

Merge branch 'refactor' of https://github.com/noelmcloughlin/rider-for...

Merge branch 'master' of https://github.com/saltstack-formulas/jetbrai...

chore(yaml): change none to null

feat(semantic-release): standardise for this formula

chore(log): enable debug kitchen output

docs(readme): add depth one

Powered by Pull Assistant. Last update d24b311 ... e0ce7f6. Read the comment docs.

* saltstack-formulas/jetbrains-rider-formula#5

myii · 2020-05-18T22:31:14Z

Thanks, @noelmcloughlin -- still had the same problem with pushing to the branch but I've figured out a way of getting around that for now.

saltstack-formulas-travis · 2020-05-18T22:41:15Z

🎉 This PR is included in version 1.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

noelmcloughlin · 2020-05-18T22:47:06Z

Is it possible *something* is disabling this? Presumably by mistake? I checked some PRs today and they all *[x] enable edits by maintainer*s because that is the default setting when creating a PR on github.com.

…

On Mon, May 18, 2020 at 11:31 PM Imran Iqbal ***@***.***> wrote: Thanks, @noelmcloughlin <https://github.com/noelmcloughlin> -- still had the same problem with pushing to the branch but I've figured out a way of getting around that for now. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#5 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ADFUUQVDHWCQXLAI6LYGAYDRSGZL7ANCNFSM4MNUQPHA> .

feat(formula): align to template-formula; add ci

d24b311

noelmcloughlin force-pushed the refactor branch from 60c98e7 to d24b311 Compare April 21, 2020 22:22

noelmcloughlin added 4 commits April 30, 2020 12:39

feat(formula): align to template-formula; add ci

ca4a346

BREAKING CHANGE: Major refactor of formula to bring it in alignment with the template-formula. As with all substantial changes, please ensure your existing configurations work in the ways you expect from this formula.

Merge branch 'refactor' of https://github.com/noelmcloughlin/rider-fo…

a399f31

…rmula into refactor

Merge branch 'master' of https://github.com/saltstack-formulas/jetbra…

7cdfb23

…ins-rider-formula into refactor

chore(yaml): change none to null

e56d32a

noelmcloughlin added 3 commits May 10, 2020 01:37

feat(semantic-release): standardise for this formula

a666df8

chore(log): enable debug kitchen output

7cdce32

docs(readme): add depth one

e0ce7f6

myii added a commit to myii/ssf-formula that referenced this pull request May 18, 2020

feat(formula): add jetbrains-rider-formula

4e6a8bc

* saltstack-formulas/jetbrains-rider-formula#5

myii mentioned this pull request May 18, 2020

feat(formula): add jetbrains-rider-formula myii/ssf-formula#188

Merged

myii merged commit 12ae9dc into saltstack-formulas:master May 18, 2020

saltstack-formulas-travis added the released label May 18, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(formula): align with template formula; add ci tests #5

feat(formula): align with template formula; add ci tests #5

noelmcloughlin commented Apr 21, 2020 •

edited

Loading

noelmcloughlin commented Apr 21, 2020

pull-assistant bot commented May 6, 2020 •

edited

Loading

myii commented May 18, 2020

saltstack-formulas-travis commented May 18, 2020

noelmcloughlin commented May 18, 2020 via email

feat(formula): align with template formula; add ci tests #5

feat(formula): align with template formula; add ci tests #5

Conversation

noelmcloughlin commented Apr 21, 2020 • edited Loading

PR progress checklist (to be filled in by reviewers)

What type of PR is this?

Primary type

Secondary type

Does this PR introduce a BREAKING CHANGE?

Related issues and/or pull requests

Describe the changes you're proposing

Pillar / config required to test the proposed changes

Debug log showing how the proposed changes work

Documentation checklist

Testing checklist

Additional context

noelmcloughlin commented Apr 21, 2020

pull-assistant bot commented May 6, 2020 • edited Loading

myii commented May 18, 2020

saltstack-formulas-travis commented May 18, 2020

noelmcloughlin commented May 18, 2020 via email

noelmcloughlin commented Apr 21, 2020 •

edited

Loading

Does this PR introduce a `BREAKING CHANGE`?

pull-assistant bot commented May 6, 2020 •

edited

Loading