feat(formula): align to template formula; add ci tests #5

noelmcloughlin · 2020-04-21T23:28:27Z

PR progress checklist (to be filled in by reviewers)

Changes to documentation are appropriate (or tick if not required)
Changes to tests are appropriate (or tick if not required)
Reviews completed

What type of PR is this?

Primary type

[build] Changes related to the build system
[chore] Changes to the build process or auxiliary tools and libraries such as documentation generation
[ci] Changes to the continuous integration configuration
[feat] A new feature
[fix] A bug fix
[perf] A code change that improves performance
[refactor] A code change that neither fixes a bug nor adds a feature
[revert] A change used to revert a previous commit
[style] Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.)

Secondary type

[docs] Documentation changes
[test] Adding missing or correcting existing tests

Does this PR introduce a `BREAKING CHANGE`?

YES

Related issues and/or pull requests

Describe the changes you're proposing

Following Intellij blueprint, align to template formula and add ci tests.

Pillar / config required to test the proposed changes

Debug log showing how the proposed changes work

Documentation checklist

Updated the README (e.g. Available states).
Updated pillar.example.

Testing checklist

Included in Kitchen (i.e. under state_top).
Covered by new/existing tests (e.g. InSpec, Serverspec, etc.).
Updated the relevant test pillar.

Additional context

…ins-clion-formula into refactor

noelmcloughlin · 2020-04-22T08:28:57Z

MacOS trace

          ID: clion-macos-app-clean-files
    Function: file.absent
        Name: /tmp/jetbrains/clion
      Result: True
     Comment: Removed directory /tmp/jetbrains/clion
     Started: 09:15:19.647100
    Duration: 121.23 ms
     Changes:   
              ----------
              removed:
                  /tmp/jetbrains/clion
----------
          ID: clion-macos-app-clean-files
    Function: file.absent
        Name: /Applications/Clion.app
      Result: True
     Comment: File /Applications/Clion.app is not present
     Started: 09:15:19.768530
    Duration: 0.334 ms
     Changes:   
----------
          ID: clion-config-clean-file-absent
    Function: file.absent
        Name: /tmp/dummy_list_item
      Result: True
     Comment: File /tmp/dummy_list_item is not present
     Started: 09:15:19.769037
    Duration: 0.316 ms
     Changes:   
----------
          ID: clion-config-clean-file-absent
    Function: file.absent
        Name: /etc/defaults/clion.sh
      Result: True
     Comment: File /etc/defaults/clion.sh is not present
     Started: 09:15:19.769507
    Duration: 0.287 ms
     Changes:   
----------
          ID: clion-config-clean-file-absent
    Function: file.absent
        Name: /Users/nmcloughlin/Desktop/Clion
      Result: True
     Comment: File /Users/nmcloughlin/Desktop/Clion is not present
     Started: 09:15:19.769939
    Duration: 0.275 ms
     Changes:   
----------
          ID: clion-macos-app-install-curl
    Function: file.directory
        Name: /tmp/jetbrains/clion
      Result: True
     Comment: Directory /tmp/jetbrains/clion updated
     Started: 09:15:19.770307
    Duration: 1.541 ms
     Changes:   
              ----------
              /tmp/jetbrains/clion:
                  New Dir
----------
          ID: clion-macos-app-install-curl
    Function: pkg.installed
        Name: curl
      Result: True
     Comment: All specified packages are already installed
     Started: 09:15:25.241845
    Duration: 11549.928 ms
     Changes:   
----------
          ID: clion-macos-app-install-curl
    Function: cmd.run
        Name: curl -Lo /tmp/jetbrains/clion/clion-2020.1 https://download.jetbrains.com/cpp/CLion-2020.1.dmg
      Result: True
     Comment: Command "curl -Lo /tmp/jetbrains/clion/clion-2020.1 https://download.jetbrains.com/cpp/CLion-2020.1.dmg" run
     Started: 09:15:36.795654
    Duration: 661023.546 ms
     Changes:   
              ----------
              pid:
                  59957
              retcode:
                  0
              stderr:
                    % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                                   Dload  Upload   Total   Spent    Left  Speed
                  
                    0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
                  100   138  100   138    0     0    830      0 --:--:-- --:--:-- --:--:--   831
                  
                    0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
                    0  461M    0  607k    0     0   514k      0  0:15:19  0:00:01  0:15:18  617k
        
                       << CUT >>

                   99  461M   99  460M    0     0   714k      0  0:11:00  0:11:00 --:--:--  827k
                  100  461M  100  461M    0     0   714k      0  0:11:00  0:11:00 --:--:--  823k
              stdout:
----------
          ID: clion-macos-app-install-checksum
    Function: module.run
        Name: file.check_hash
      Result: True
     Comment: onlyif condition is false
     Started: 09:26:37.822843
    Duration: 1008.643 ms
     Changes:   
----------
          ID: clion-macos-app-install-checksum
    Function: file.absent
        Name: /tmp/jetbrains/clion/clion-2020.1
      Result: True
     Comment: State was not run because onfail req did not change
     Started: 09:26:38.832289
    Duration: 0.003 ms
     Changes:   
----------
          ID: clion-macos-app-install-macpackage
    Function: macpackage.installed
        Name: /tmp/jetbrains/clion/clion-2020.1
      Result: True
     Comment: CLion.app installed
     Started: 09:26:38.832510
    Duration: 30014.135 ms
     Changes:   
              ----------
              installed:
                  - CLion.app
----------
          ID: clion-macos-app-install-macpackage
    Function: file.managed
        Name: /tmp/mac_shortcut.sh
      Result: True
     Comment: File /tmp/mac_shortcut.sh is in the correct state
     Started: 09:27:08.847011
    Duration: 246.493 ms
     Changes:   
----------
          ID: clion-macos-app-install-macpackage
    Function: cmd.run
        Name: /tmp/mac_shortcut.sh
      Result: True
     Comment: Command "/tmp/mac_shortcut.sh" run
     Started: 09:27:09.094106
    Duration: 1771.075 ms
     Changes:   
              ----------
              pid:
                  61254
              retcode:
                  0
              stderr:
              stdout:
                  alias file CLion of folder Desktop of folder nmcloughlin of folder Users of startup disk
----------
          ID: clion-config-file-file-managed-environ_file
    Function: file.managed
        Name: /etc/defaults/clion.sh
      Result: True
     Comment: File /etc/defaults/clion.sh updated
     Started: 09:27:10.865657
    Duration: 1896.586 ms
     Changes:   
              ----------
              diff:
                  New file
              group:
                  nmcloughlin
              mode:
                  0644
              user:
                  nmcloughlin

Summary for local
-------------
Succeeded: 14 (changed=6)
Failed:     0

BREAKING CHANGE: Major refactor of formula to bring it in alignment with the template-formula. As with all substantial changes, please ensure your existing configurations work in the ways you expect from this formula.

…rmula into refactor

pull-assistant · 2020-05-06T19:55:54Z

Best reviewed: commit by commit

Optimal code review plan (1 warning)

feat(formula): align to template-formula; add ci

clion/init.sls 53% changes removed in feat(formula): align...

clion/map.jinja 83% changes removed in feat(formula): align...

FORMULA 88% changes removed in feat(formula): align...

pillar.example 60% changes removed in feat(formula): align...

Merge branch 'master' of https://github.com/saltstack-formulas/jetbrai...

feat(formula): align to template-formula; add ci

Merge branch 'refactor' of https://github.com/noelmcloughlin/clion-for...

chore(yaml): change none to null

feat(semantic-release): standardise for this formula

fix(id): rename conflicting id

chore(log): enable debug kitchen output

docs(readme): add depth one

Powered by Pull Assistant. Last update d16bd3a ... 2e1cec2. Read the comment docs.

* saltstack-formulas/jetbrains-clion-formula#5

myii · 2020-06-01T04:37:15Z

Added a couple of commits to get the latest pre-salted images as well as fix the links to Travis in the README:

saltstack-formulas-travis · 2020-06-01T04:38:27Z

🎉 This PR is included in version 1.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

noelmcloughlin added 2 commits April 21, 2020 20:32

feat(formula): align to template-formula; add ci

d16bd3a

Merge branch 'master' of https://github.com/saltstack-formulas/jetbra…

ce9d863

…ins-clion-formula into refactor

noelmcloughlin added 3 commits April 30, 2020 12:41

feat(formula): align to template-formula; add ci

6bed46d

BREAKING CHANGE: Major refactor of formula to bring it in alignment with the template-formula. As with all substantial changes, please ensure your existing configurations work in the ways you expect from this formula.

Merge branch 'refactor' of https://github.com/noelmcloughlin/clion-fo…

6600ad4

…rmula into refactor

chore(yaml): change none to null

d40bf5c

noelmcloughlin added 4 commits May 10, 2020 01:23

feat(semantic-release): standardise for this formula

81c583f

fix(id): rename conflicting id

ac29163

chore(log): enable debug kitchen output

9472fb8

docs(readme): add depth one

2e1cec2

myii added a commit to myii/ssf-formula that referenced this pull request Jun 1, 2020

feat(formula): add jetbrains-clion-formula

15c96c6

* saltstack-formulas/jetbrains-clion-formula#5

myii mentioned this pull request Jun 1, 2020

feat(formula): add jetbrains-clion-formula myii/ssf-formula#210

Merged

myii merged commit b24bb96 into saltstack-formulas:master Jun 1, 2020

saltstack-formulas-travis added the released label Jun 1, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(formula): align to template formula; add ci tests #5

feat(formula): align to template formula; add ci tests #5

noelmcloughlin commented Apr 21, 2020 •

edited

Loading

noelmcloughlin commented Apr 22, 2020

pull-assistant bot commented May 6, 2020 •

edited

Loading

myii commented Jun 1, 2020

saltstack-formulas-travis commented Jun 1, 2020

feat(formula): align to template formula; add ci tests #5

feat(formula): align to template formula; add ci tests #5

Conversation

noelmcloughlin commented Apr 21, 2020 • edited Loading

PR progress checklist (to be filled in by reviewers)

What type of PR is this?

Primary type

Secondary type

Does this PR introduce a BREAKING CHANGE?

Related issues and/or pull requests

Describe the changes you're proposing

Pillar / config required to test the proposed changes

Debug log showing how the proposed changes work

Documentation checklist

Testing checklist

Additional context

noelmcloughlin commented Apr 22, 2020

pull-assistant bot commented May 6, 2020 • edited Loading

myii commented Jun 1, 2020

saltstack-formulas-travis commented Jun 1, 2020

noelmcloughlin commented Apr 21, 2020 •

edited

Loading

Does this PR introduce a `BREAKING CHANGE`?

pull-assistant bot commented May 6, 2020 •

edited

Loading