feat(semantic-release): implement for this formula #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Automated using myii/ssf-formula#109
```bash
[202] Jinja statement should have spaces before and after: {% statement %}
icinga2/config.sls:6
{%- for key, value in config.items()%}
[206] Jinja variables should have spaces before and after: {{ var_name }}
icinga2/config.sls:8
{{key}} "{{ value }}"
[202] Jinja statement should have spaces before and after: {% statement %}
icinga2/config.sls:12
{%- for key, value in config.items()%}
[202] Jinja statement should have spaces before and after: {% statement %}
icinga2/config.sls:55
{%-endmacro%}
[206] Jinja variables should have spaces before and after: {{ var_name }}
icinga2/config.sls:107
{{ path}}:
[202] Jinja statement should have spaces before and after: {% statement %}
icinga2/config.sls:160
{%- endfor%}
[202] Jinja statement should have spaces before and after: {% statement %}
icinga2/config.sls:181
{%- endfor%}
[202] Jinja statement should have spaces before and after: {% statement %}
icinga2/config.sls:202
{%- endfor%}
[202] Jinja statement should have spaces before and after: {% statement %}
icinga2/config.sls:227
{%- endfor%}
[202] Jinja statement should have spaces before and after: {% statement %}
icinga2/config.sls:230
{%- endfor%}
[201] Trailing whitespace
icinga2/files/xmpp.conf.jinja:3
[201] Trailing whitespace
icinga2/files/xmpp.conf.jinja:9
[201] Trailing whitespace
icinga2/files/xmpp.conf.jinja:21
[201] Trailing whitespace
icinga2/files/xmpp.conf.jinja:24
[201] Trailing whitespace
icinga2/files/xmpp.conf.jinja:27
[201] Trailing whitespace
icinga2/files/xmpp.conf.jinja:31
[201] Trailing whitespace
icinga2/files/xmpp.conf.jinja:33
[201] Trailing whitespace
icinga2/files/xmpp.conf.jinja:35
[201] Trailing whitespace
icinga2/files/xmpp.conf.jinja:38
[201] Trailing whitespace
icinga2/files/xmpp.conf.jinja:41
[201] Trailing whitespace
icinga2/files/xmpp.conf.jinja:44
[201] Trailing whitespace
icinga2/files/xmpp.conf.jinja:49
[201] Trailing whitespace
icinga2/files/xmpp.conf.jinja:51
[201] Trailing whitespace
icinga2/files/xmpp.conf.jinja:53
[201] Trailing whitespace
icinga2/map.jinja:6
defaults,
[202] Jinja statement should have spaces before and after: {% statement %}
icinga2/nrpe-server.sls:2
{% set nrpe = salt['pillar.get']('nrpe', salt['pillar.get']('icinga2:lookup::nrpe', {}))%}
[206] Jinja variables should have spaces before and after: {{ var_name }}
icinga2/pgsql-ido.sls:45
- name: "{{ icinga2.config_dir}}/features-available/ido-pgsql.conf"
```
```bash icinga2-formula$ yamllint -s . ./pillar.example 1:1 warning missing document start "---" (document-start) 6:8 warning missing starting space in comment (comments) 20:14 warning truthy value should be one of [false, true] (truthy) 21:18 warning truthy value should be one of [false, true] (truthy) 22:15 warning truthy value should be one of [false, true] (truthy) 23:19 warning truthy value should be one of [false, true] (truthy) 24:19 warning truthy value should be one of [false, true] (truthy) 25:19 warning truthy value should be one of [false, true] (truthy) 26:21 warning truthy value should be one of [false, true] (truthy) 36:18 warning truthy value should be one of [false, true] (truthy) 103:9 warning comment not indented like content (comments-indentation) 109:17 warning truthy value should be one of [false, true] (truthy) 123:15 error empty value in block mapping (empty-values) 124:7 warning comment not indented like content (comments-indentation) 126:14 error empty value in block mapping (empty-values) 127:7 warning comment not indented like content (comments-indentation) ./icinga2/osmap.yaml 1:1 warning missing document start "---" (document-start) ./icinga2/defaults.yaml 1:1 warning missing document start "---" (document-start) 14:27 warning truthy value should be one of [false, true] (truthy) 20:16 error empty value in block mapping (empty-values) 34:16 error empty value in block mapping (empty-values) 51:12 warning truthy value should be one of [false, true] (truthy) 52:16 warning truthy value should be one of [false, true] (truthy) 53:17 warning truthy value should be one of [false, true] (truthy) 54:13 warning truthy value should be one of [false, true] (truthy) 55:17 warning truthy value should be one of [false, true] (truthy) 56:17 warning truthy value should be one of [false, true] (truthy) 57:19 warning truthy value should be one of [false, true] (truthy) 58:17 warning truthy value should be one of [false, true] (truthy) 59:17 warning truthy value should be one of [false, true] (truthy) 60:19 warning truthy value should be one of [false, true] (truthy) 61:15 warning truthy value should be one of [false, true] (truthy) ./icinga2/osfamilymap.yaml 1:1 warning missing document start "---" (document-start) 5:27 warning truthy value should be one of [false, true] (truthy) 16:19 error empty value in block mapping (empty-values) 17:2 error syntax error: found character '%' that cannot start any token ```
Merged
|
@myii do you want it merged? |
|
@myii merged it, nice !!! |
|
@aboe76 Thanks. |
|
🎉 This PR is included in version 0.8.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR progress checklist (to be filled in by reviewers)
What type of PR is this?
Primary type
[build]Changes related to the build system[chore]Changes to the build process or auxiliary tools and libraries such as documentation generation[ci]Changes to the continuous integration configuration[feat]A new feature[fix]A bug fix[perf]A code change that improves performance[refactor]A code change that neither fixes a bug nor adds a feature[revert]A change used to revert a previous commit[style]Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.)Secondary type
[docs]Documentation changes[test]Adding missing or correcting existing testsDoes this PR introduce a
BREAKING CHANGE?No.
Related issues and/or pull requests
icinga2-formulamyii/ssf-formula#109Describe the changes you're proposing
Standard
semantic-releasePR; some minor fixes required.Pillar / config required to test the proposed changes
As provided in the test pillar.
Debug log showing how the proposed changes work
As shown in Travis.
Documentation checklist
README(e.g.Available states).pillar.example.Testing checklist
state_top).Additional context