Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Copier template 0.3.7 #37

Merged
merged 3 commits into from
Aug 8, 2024
Merged

Conversation

lkubb
Copy link
Member

@lkubb lkubb commented Jul 23, 2024

What does this PR do?

Updates the Copier template to 0.3.7.

  • Fixes the docs build in CI
  • Publishes docs to GitHub Pages

What issues does this PR fix or reference?

Fixes:

Merge requirements satisfied?

[NOTICE] Bug fixes or features added to Salt require tests.

Commits signed with GPG?

Yes

@lkubb lkubb requested a review from max-arnold July 23, 2024 08:21
@max-arnold
Copy link

@lkubb I'm on vacation at the moment, will be able to take a look in August

@lkubb
Copy link
Member Author

lkubb commented Jul 23, 2024

@max-arnold Thanks for the response! No worries, hope you enjoy your vacation. :)

It's just a boilerplate update, but I didn't feel comfortable overriding the branch protection.

max-arnold
max-arnold previously approved these changes Aug 4, 2024
@lkubb lkubb changed the title Update to Copier template 0.3.3 Update to Copier template 0.3.7 Aug 5, 2024
@lkubb
Copy link
Member Author

lkubb commented Aug 5, 2024

@max-arnold Thanks for reviewing and sorry for dismissing, opted to update this again to avoid CI failures after a merge with the new workflow permissions.

Maybe you can check out the new commit as well. If you're fine with the changes here, I don't think we'll need separate reviews for similar updates to the other extension repos.

To enable the docs publishing, this update currently needs to happen manually once for each existing extension repo (while writing this, I think I could make it automatic in a new template version). Most further updates can be handled using the new Renovate support for Copier (my initial PR allowed defining organization-wide template defaults, which would have made this process automatic, but the Renovate maintainers did not want to include any Copier-specific configuration in the initial release). Just need to wait for one Copier fix I submitted last week that avoids recreation of deleted files.

Copy link

@max-arnold max-arnold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lkubb lkubb merged commit fb277a2 into salt-extensions:main Aug 8, 2024
18 checks passed
@lkubb lkubb deleted the copier-update branch August 8, 2024 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants