Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to copier profile and centralize workflows #35

Merged

Conversation

nicholasmhughes
Copy link
Member

What does this PR do?

Migrate to copier profile and centralize workflows

Commits signed with GPG?

Yes

Please review Salt's Contributing Guide for best practices.

See GitHub's page on GPG signing for more information about signing commits with GPG.

@codecov-commenter
Copy link

codecov-commenter commented Jan 1, 2024

Codecov Report

Attention: 65 lines in your changes are missing coverage. Please review.

Comparison is base (9e772bb) 70.68% compared to head (246965a) 66.79%.

❗ Current head 246965a differs from pull request most recent head 957f4f0. Consider uploading reports for the commit 957f4f0 to get more accurate results

Files Patch % Lines
tests/unit/conftest.py 20.51% 31 Missing ⚠️
tests/functional/conftest.py 55.35% 25 Missing ⚠️
tests/conftest.py 40.00% 2 Missing and 1 partial ⚠️
tests/integration/conftest.py 0.00% 3 Missing ⚠️
tests/support/mock.py 40.00% 3 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #35      +/-   ##
==========================================
- Coverage   70.68%   66.79%   -3.89%     
==========================================
  Files           7        8       +1     
  Lines         672      777     +105     
  Branches       72       76       +4     
==========================================
+ Hits          475      519      +44     
- Misses        191      251      +60     
- Partials        6        7       +1     
Flag Coverage Δ
Linux 66.79% <45.83%> (-3.89%) ⬇️
project 81.86% <100.00%> (-0.85%) ⬇️
py310 66.79% <45.83%> (-3.89%) ⬇️
py37 ?
py38 66.88% <45.83%> (-3.91%) ⬇️
py39 66.88% <45.83%> (-3.91%) ⬇️
salt_3005_4 66.88% <45.83%> (?)
salt_3006_1 ?
salt_3006_4 66.79% <45.83%> (?)
tests 61.03% <42.98%> (-4.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nicholasmhughes nicholasmhughes merged commit f347632 into salt-extensions:main Jan 1, 2024
17 checks passed
@nicholasmhughes nicholasmhughes deleted the copier-profile branch January 1, 2024 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants