chore(deps): upgrade to broccoli-postcss 4
#124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @alexlafroscia! We dropped Node 4 and 9 support in the 1.0 release, so we should be good there. Based on the changelog, it doesn't look like this should be breaking for our consumers, so I'm happy to put this out in a patch release. |
|
Released in |
|
Awesome, thanks so much @dfreeman ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We ran into a bug due to the previous
broccoli-postcss's strict reliance on a specificbroccoli-persistent-filterversionThe
broccoli-postcssupgrade brings the PostCSS version up to 7. This might mean that landing this PR would require a breaking change here, too.Both the major-version bump in PostCSS and the broccoli plugin drop Node 4 and 9 support, but this addon never tried to be compatible with either of those anyway, based on the declared
engine. PostCSS does have some other breaking changes around browser support, however, but it's mostly for dead browsers. You can find the relevant changelog here.