Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature | Add a NullAuthenticator to overwrite defaultAuth #423

Merged
merged 4 commits into from
Jun 9, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions src/Http/Auth/NullAuthenticator.php
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
<?php

declare(strict_types=1);

namespace Saloon\Http\Auth;

use Saloon\Http\PendingRequest;
use Saloon\Contracts\Authenticator;

class NullAuthenticator implements Authenticator
{
/**
* Apply the authentication to the request.
*/
public function set(PendingRequest $pendingRequest): void
{
//
}
}
13 changes: 13 additions & 0 deletions tests/Unit/AuthenticatesRequestsTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -4,11 +4,13 @@

use GuzzleHttp\RequestOptions;
use Saloon\Exceptions\SaloonException;
use Saloon\Http\Auth\NullAuthenticator;
use Saloon\Http\Auth\MultiAuthenticator;
use Saloon\Http\Auth\TokenAuthenticator;
use Saloon\Http\Auth\HeaderAuthenticator;
use Saloon\Tests\Fixtures\Requests\UserRequest;
use Saloon\Tests\Fixtures\Connectors\ArraySenderConnector;
use Saloon\Tests\Fixtures\Connectors\DefaultAuthenticatorConnector;

test('you can add basic auth to a request', function () {
$request = new UserRequest;
Expand Down Expand Up @@ -106,3 +108,14 @@
'X-API-Key' => 'api-key',
]);
});

test('you can use a null authenticator to disable default authentication entirely', function () {
$connector = new DefaultAuthenticatorConnector;
$request = new UserRequest;

$request->authenticate(new NullAuthenticator);

$pendingRequest = $connector->createPendingRequest($request);

expect($pendingRequest->headers()->all())->toEqual(['Accept' => 'application/json']);
});
Loading