Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate from Travis to GitHub Actions; actions implementation needs to be kept in sync with NodeJS releases ... #213

Closed
awaterma opened this issue May 5, 2021 · 2 comments · Fixed by #218
Closed

Migrate from Travis to GitHub Actions; actions implementation needs to be kept in sync with NodeJS releases ... #213

awaterma opened this issue May 5, 2021 · 2 comments · Fixed by #218
Assignees
@awaterma
Milestone
4.x Release

Comments

@awaterma
Copy link
Member

awaterma commented May 5, 2021

We need to keep our Travis testing in sycn with NodeJS releases: https://nodejs.org/en/about/releases/
@awaterma awaterma self-assigned this May 5, 2021
@awaterma awaterma added this to the 4.x Release milestone Jun 21, 2021
@awaterma
Copy link
Member Author

We want to also add another integration testing framework that won't limit our use, but we think we want to retain Travis.

@awaterma awaterma changed the title Need to update Travis NodeJS Versions Migrate from Travis to GitHub Actions; actions implementation needs to be kept in sync with NodeJS releases ... Sep 17, 2021
@awaterma
Copy link
Member Author

Looking at: https://github.com/actions/setup-node, for this work.

awaterma added a commit to awaterma/tough-cookie that referenced this issue Sep 21, 2021
@awaterma
Issue salesforce#213 -- added gh-actions flow for building and testin…
7d63bae 
…g tough-cookie with all current version of node. This should replace our Travis testing.
@awaterma awaterma linked a pull request Sep 22, 2021 that will close this issue
Issue #213 -- added gh-actions flow for building and testing tough-co… #218
Merged
awaterma added a commit that referenced this issue Sep 27, 2021
@awaterma
Issue #213 -- added gh-actions flow for building and testing tough-co… (
713403e 
#218)

* Issue #213 -- added gh-actions flow for building and testing tough-cookie with all current version of node. This should replace our Travis testing.
* 213 -- Updated target branch for workflow.
wjhsf pushed a commit that referenced this issue Feb 8, 2024
@nolanlawson @pmdartus
chore(package): update reference to git repo (#213)
f631358 
* chore(package): update reference to git repo

* fix: update package.json

Co-authored-by: Pierre-Marie Dartus <p.dartus@salesforce.com>

Co-authored-by: Pierre-Marie Dartus <p.dartus@salesforce.com>
@botanical botanical mentioned this issue May 20, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@awaterma awaterma

Labels
None yet
Projects
None yet
Milestone
4.x Release
Development

Successfully merging a pull request may close this issue.

Issue #213 -- added gh-actions flow for building and testing tough-co… awaterma/tough-cookie
1 participant
@awaterma