Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Code Coverage for RichMetadata #70

Merged
merged 9 commits into from
Aug 19, 2018
Merged

Improve Code Coverage for RichMetadata #70

merged 9 commits into from
Aug 19, 2018

Conversation

himsmittal
Copy link
Contributor

@himsmittal himsmittal commented Aug 19, 2018 •
edited
Loading

Improve Code Coverage for RichMetadata.
Added more test cases.

@himsmittal himsmittal changed the title Hm/coverage Improve Code Coverage for RichMetadata Aug 19, 2018
@codecov
Copy link

codecov bot commented Aug 19, 2018 •
edited
Loading

Codecov Report

Merging #70 into master will increase coverage by 0.32%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #70      +/-   ##
==========================================
+ Coverage   85.79%   86.12%   +0.32%     
==========================================
  Files         298      298              
  Lines        9760     9760              
  Branches      535      535              
==========================================
+ Hits         8374     8406      +32     
+ Misses       1386     1354      -32
Impacted Files Coverage Δ
...a/org/apache/spark/sql/types/MetadataWrapper.scala 25% <0%> (+25%) ⬆️
...a/com/salesforce/op/utils/spark/RichMetadata.scala 79.24% <0%> (+54.71%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ad89426...6d502b6. Read the comment docs.

tovbinm
tovbinm approved these changes Aug 19, 2018
View reviewed changes
Copy link
Collaborator

@tovbinm tovbinm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm! One minor comment.

utils/src/test/scala/com/salesforce/op/utils/spark/RichMetadataTest.scala Outdated

private val meta1 = map1.toMetadata

implicit val formats: DefaultFormats.type = DefaultFormats
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to specify “.type”

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@tovbinm tovbinm merged commit fc64f2a into salesforce:master Aug 19, 2018
@tovbinm
Copy link
Collaborator

tovbinm commented Aug 19, 2018

Thanks! Please update your branch from up stream master before next PR.

ericwayman pushed a commit that referenced this pull request Feb 8, 2019
@himsmittal @tovbinm
Improve Code Coverage for RichMetadata (#70)
36f5973
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tovbinm tovbinm tovbinm approved these changes

@leahmcguire leahmcguire Awaiting requested review from leahmcguire leahmcguire is a code owner

Assignees
No one assigned
Labels
cla:signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@himsmittal @tovbinm