Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed logging of tokens #420

Merged
merged 2 commits into from
Oct 11, 2019
Merged

removed logging of tokens #420

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
80838f6
removed logging of tolens
leahmcguire Oct 11, 2019
2b7077e
fixed test
leahmcguire Oct 11, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion core/src/main/scala/com/salesforce/op/filters/FeatureDistribution.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,7 +167,6 @@ case class FeatureDistribution
"nulls" -> nulls.toString,
"distribution" -> distribution.mkString("[", ",", "]"),
"summaryInfo" -> summaryInfo.mkString("[", ",", "]"),
"cardinality" -> cardEstimate.map(_.toString).getOrElse(""),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@leahmcguire was there any value in what @TuanNguyen27 was doing in e0ea2ed#diff-528878f8bd336b485dd82f1fbef950f7R281

seq.map(_.size.toString)

which we could still do in toString

"moments" -> moments.map(_.toString).getOrElse("")
).map { case (n, v) => s"$n = $v" }.mkString(", ")

Expand Down
2 changes: 1 addition & 1 deletion core/src/test/scala/com/salesforce/op/filters/FeatureDistributionTest.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,7 +196,7 @@ class FeatureDistributionTest extends FlatSpec with PassengerSparkFixtureTest wi
it should "have toString" in {
FeatureDistribution("A", None, 10, 1, Array(1, 4, 0, 0, 6), Array.empty).toString() shouldBe
"FeatureDistribution(type = Training, name = A, key = None, count = 10, nulls = 1, " +
"distribution = [1.0,4.0,0.0,0.0,6.0], summaryInfo = [], cardinality = , moments = )"
"distribution = [1.0,4.0,0.0,0.0,6.0], summaryInfo = [], moments = )"
}

it should "marshall to/from json" in {
Expand Down