Serialization for FeatureGeneratorStage #300
Conversation
Codecov Report
@@ Coverage Diff @@
## mt/function-arguments-merged #300 +/- ##
================================================================
- Coverage 86.33% 85.94% -0.39%
================================================================
Files 325 325
Lines 10511 10576 +65
Branches 338 548 +210
================================================================
+ Hits 9075 9090 +15
- Misses 1436 1486 +50
Continue to review full report at Codecov.
|
| @@ -138,6 +138,8 @@ class OpWorkflowModelReader(val workflowOpt: Option[OpWorkflow]) extends MLReade | |||
| val originalStage = workflow.stages.find(_.uid == stageUid) | |||
| originalStage match { | |||
| case Some(os) => new OpPipelineStageReader(os).loadFromJson(j, path = path).asInstanceOf[OPStage] | |||
| case None if stageUid.startsWith("FeatureGeneratorStage_") => | |||
There was a problem hiding this comment.
classOf[FeatureGeneratorStage].getSimpleName instead of string
| aggregator = new CustomMonoidAggregator[O](associativeFn = fn, zero = zero)(tto) | ||
| this | ||
| } | ||
|
|
There was a problem hiding this comment.
why are these deleted? they have an important function
| @@ -181,6 +181,9 @@ class FeatureBuilderTest extends FlatSpec with TestSparkContext { | |||
|
|
|||
| } | |||
|
|
|||
| object TestCustomMonoidAggregator extends CustomMonoidAggregator[Real](zero = Real.empty.v, | |||
There was a problem hiding this comment.
so people need to instantiate the class for the aggregation function?
| object TestMonoidAggregator | ||
| extends CustomMonoidAggregator[Real](None, (l, r) => (l -> r).map(breeze.linalg.max(_, _))) with Serializable | ||
|
|
||
| object PassengerFeaturesTestLambdas { |
There was a problem hiding this comment.
do you need the functions defined this way or is it a style thing?
|
@leahmcguire it's WIP, not for review yet ;) |
|
Superseeded by #309 |
Only saving to JSON