Spec-ifying ngram similarity tests #299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #299 +/- ##
========================================
Coverage 86.42% 86.42%
========================================
Files 322 322
Lines 10570 10570
Branches 350 572 +222
========================================
Hits 9135 9135
Misses 1435 1435Continue to review full report at Codecov.
|
tovbinm
approved these changes
Apr 19, 2019
tovbinm
reviewed
Apr 19, 2019
| ) | ||
|
|
||
| val(dsText, f1Text, f2Text) = TestFeatureBuilder( | ||
| class TextNGramSimilarityTest extends OpTransformerSpec[RealNN, NGramSimilarity[Text]]{ |
There was a problem hiding this comment.
why not use the correct type here?
class TextNGramSimilarityTest extends OpTransformerSpec[RealNN, TextNGramSimilarity]and the same for the other test
Merged
Closed
|
Thanks for the contribution! It looks like @snabar is an internal user so signing the CLA is not required. However, we need to confirm this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Converting NGramSimilarityTest to use OpTransformerSpec