Improved multi pick list map vectorizer test #292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ultiPickListMapVectorizerTest
…ultiPickListMapVectorizerTest
tovbinm
reviewed
Apr 17, 2019
| @@ -94,8 +94,7 @@ final class MultiPickListMapVectorizerModel[T <: OPMap[Set[String]]] private[op] | |||
| operationName: String, | |||
| uid: String | |||
| )(implicit tti: TypeTag[T]) | |||
| extends SequenceModel[T, OPVector](operationName = operationName, uid = uid) | |||
| with VectorizerDefaults with CleanTextMapFun { | |||
| extends SequenceModel[T, OPVector](operationName = operationName, uid = uid) with CleanTextMapFun { | |||
There was a problem hiding this comment.
@wsuchy please also remove VectorizerDefaults mixin from MultiPickListMapVectorizer class
tovbinm
reviewed
Apr 17, 2019
| @@ -46,11 +46,20 @@ import org.slf4j.LoggerFactory | |||
|
|
|||
|
|
|||
| @RunWith(classOf[JUnitRunner]) | |||
| class MultiPickListMapVectorizerTest extends FlatSpec with TestSparkContext with AttributeAsserts { | |||
| class MultiPickListMapVectorizerTest extends | |||
| OpEstimatorSpec[OPVector, SequenceModel[MultiPickListMap, OPVector], MultiPickListMapVectorizer[MultiPickListMap]] | |||
There was a problem hiding this comment.
better put the newline before the extends
class MultiPickListMapVectorizerTest
extends OpEstimatorSpec[...] {
}
tovbinm
reviewed
Apr 17, 2019
| @@ -70,7 +79,8 @@ class MultiPickListMapVectorizerTest extends FlatSpec with TestSparkContext with | |||
| lazy val (dataSetAllEmpty, _) = TestFeatureBuilder(top.name, | |||
| Seq(MultiPickListMap.empty, MultiPickListMap.empty, MultiPickListMap.empty)) | |||
|
|
|||
| val vectorizer = new MultiPickListMapVectorizer().setCleanKeys(true).setMinSupport(0).setTopK(10).setInput(top, bot) | |||
| val estimator:MultiPickListMapVectorizer[MultiPickListMap] | |||
There was a problem hiding this comment.
idents:
val estimator: MultiPickListMapVectorizer[MultiPickListMap] =
new MultiPickListMapVectorizer()...
Codecov Report
@@ Coverage Diff @@
## master #292 +/- ##
======================================
Coverage 86.4% 86.4%
======================================
Files 319 319
Lines 10452 10452
Branches 346 346
======================================
Hits 9031 9031
Misses 1421 1421
Continue to review full report at Codecov.
|
Merged
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
..and another test fixed