-
Notifications
You must be signed in to change notification settings - Fork 397
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix ModelInsights for xgboost #170
Conversation
Thanks for the contribution! Unfortunately we can't verify the commit author(s): kinfai.kan <k***@s***.com>. One possible solution is to add that email to your GitHub account. Alternatively you can change your commits to another email and force push the change. After getting your commits associated with your GitHub account, refresh the status of this Pull Request. |
* @param featureVectorSize | ||
* @return | ||
*/ | ||
def getFeatureScoreVector(featureVectorSize: Option[Int]): Vector = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- why use
Vector
as return type for if you are doing totoArray
anyways? - should we have a default value
featureVectorSize: Option[Int] = None
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
…xgboostModelInsights
Codecov Report
@@ Coverage Diff @@
## master #170 +/- ##
==========================================
+ Coverage 86.25% 86.29% +0.04%
==========================================
Files 305 305
Lines 9950 9963 +13
Branches 319 549 +230
==========================================
+ Hits 8582 8598 +16
+ Misses 1368 1365 -3
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Thanks for the contribution! It looks like @kinfaikan is an internal user so signing the CLA is not required. However, we need to confirm this. |
Related issues
OpWorkflowModel::modelInsights
fails for xgboost because feature scores are not extracted correctlyDescribe the proposed solution
Convert feature score map to a vector in
ModelInsights::getModelInsights
Handle null stage param values in
ModelInsights::getStageInfo
Do not create a table when no validation results is found
Describe alternatives you've considered
NA
Additional context
NA