-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add go to definition for imports #3
feat: add go to definition for imports #3
Conversation
Thanks for the contribution! Before we can merge this, we need @PeterCardenas to sign the Salesforce Inc. Contributor License Agreement. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At least for my personal neo-vim configuration (where I only have keybindings for go-to-definition), this is certainly an improvement. Thanks for opening this Pull Request!
Did you double-check what the behavior in VS-Code is, if there is both a link and a "go-to-definition" available on the same line?
Oh, and I do actually need you to Salesforce CLA before I can merge this |
that's weird, it says i signed it already (i did try before when i put up the pr but there was some error i didn't get back to) |
🤔 maybe the check only re-triggers when something in the Pull Request gets changed. Let's see if this gets auto-resolved after updating the code |
ope looks like that was it, i'll check vscode when i get a chance to set it up. i have neovim setup with document link support with lsplinks and both still work fine tho |
I verified that this also works for VS-Code |
Adds the go to definition capability for navigating to import files. This functionality already exists via document link, but I think it's more/also appropriate as a definition.
I can also imagine going to definition for flag aliases as well as targets in the future.