Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "Enable" and "Disable" FrameV2 events when enable signal changes state. #5

Merged
merged 3 commits into from
Jun 5, 2020

Conversation

Marcus10110
Copy link
Contributor

No description provided.

@Marcus10110 Marcus10110 requested a review from huffman June 5, 2020 20:09
Copy link
Contributor

@huffman huffman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just had 1 comment on the type names.

src/SpiAnalyzer.cpp Outdated Show resolved Hide resolved
src/SpiAnalyzer.cpp Outdated Show resolved Hide resolved
Marcus10110 and others added 2 commits June 5, 2020 15:27
Co-authored-by: Ryan Huffman <ryanhuffman@gmail.com>
Co-authored-by: Ryan Huffman <ryanhuffman@gmail.com>
@Marcus10110 Marcus10110 requested a review from huffman June 5, 2020 22:27
@Marcus10110 Marcus10110 merged commit 182d58d into alpha Jun 5, 2020
@Marcus10110 Marcus10110 deleted the feature/framev2-enable-disable branch June 5, 2020 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants