Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for master key clients to create user sessions (#7406) #6

Merged
merged 1 commit into from
Jun 5, 2021

Conversation

sakibguy
Copy link
Owner

@sakibguy sakibguy commented Jun 5, 2021

  • 6641: Implement support for user impersonation: master key clients can log in as any user, without access to the user's credentials, and without presuming the user already has a session

  • reworded changelog

  • rebuilt package lock

  • fit test

  • using lodash flatMap

  • bump to node 12 for postgres test

  • revert test fit

  • add node version to postgres CI

  • revert package-lock

Co-authored-by: gormanfletcher git@gormanfletcher.com
Co-authored-by: Manuel 5673677+mtrezza@users.noreply.github.com

New Pull Request Checklist

Issue Description

Related issue: FILL_THIS_OUT

Approach

TODOs before merging

  • Add test cases
  • Add entry to changelog
  • Add changes to documentation (guides, repository pages, in-code descriptions)
  • Add security check
  • Add new Parse Error codes to Parse JS SDK
  • ...

* 6641: Implement support for user impersonation: master key clients can log in as any user, without access to the user's credentials, and without presuming the user already has a session

* reworded changelog

* rebuilt package lock

* fit test

* using lodash flatMap

* bump to node 12 for postgres test

* revert test fit

* add node version to postgres CI

* revert package-lock

Co-authored-by: gormanfletcher <git@gormanfletcher.com>
Co-authored-by: Manuel <5673677+mtrezza@users.noreply.github.com>
@sakibguy sakibguy added the enhancement New feature or request label Jun 5, 2021
@sakibguy sakibguy self-assigned this Jun 5, 2021
@codecov-commenter
Copy link

codecov-commenter commented Jun 5, 2021

Codecov Report

Merging #6 (129f7bf) into master (4b8d254) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #6      +/-   ##
==========================================
+ Coverage   93.92%   93.94%   +0.02%     
==========================================
  Files         181      181              
  Lines       13210    13245      +35     
==========================================
+ Hits        12407    12443      +36     
+ Misses        803      802       -1     
Impacted Files Coverage Δ
src/RestQuery.js 95.70% <100.00%> (+0.17%) ⬆️
src/Routers/ClassesRouter.js 97.95% <100.00%> (ø)
src/Routers/UsersRouter.js 94.38% <100.00%> (+0.59%) ⬆️
src/ParseServerRESTController.js 98.50% <0.00%> (+1.49%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 754c127...129f7bf. Read the comment docs.

@sakibguy sakibguy merged commit 58a8e67 into sakibguy:master Jun 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants