Fix: list items aren't reset when page is collapsed immediately

This usually happens when battery saver is on.
saket · Jul 30, 2019 · 5217691 · 5217691
1 parent bbf7b56
commit 5217691
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/...clerview/src/main/java/me/saket/inboxrecyclerview/animation/PageLocationChangeDetector.kt b/...clerview/src/main/java/me/saket/inboxrecyclerview/animation/PageLocationChangeDetector.kt
@@ -5,8 +5,8 @@ import android.view.ViewTreeObserver
 import me.saket.inboxrecyclerview.page.ExpandablePageLayout
 
 internal class PageLocationChangeDetector(
-    private val page: ExpandablePageLayout,
-    private val changeListener: () -> Unit
+  private val page: ExpandablePageLayout,
+  private val changeListener: () -> Unit
 ) : ViewTreeObserver.OnPreDrawListener, ViewTreeObserver.OnGlobalLayoutListener {
 
   private var lastTranslationY = 0F
@@ -28,7 +28,7 @@ internal class PageLocationChangeDetector(
     val dimensionsChanged = lastClippedDimens != page.clippedDimens
     val stateChanged = lastState != page.currentState
 
-    if (page.isCollapsed.not() && (moved || dimensionsChanged || stateChanged)) {
+    if (moved || dimensionsChanged || stateChanged) {
       changeListener()
     }
 

diff --git a/inboxrecyclerview/src/main/java/me/saket/inboxrecyclerview/page/ExpandablePageLayout.kt b/inboxrecyclerview/src/main/java/me/saket/inboxrecyclerview/page/ExpandablePageLayout.kt
@@ -173,7 +173,7 @@ open class ExpandablePageLayout @JvmOverloads constructor(
   override fun onRelease(collapseEligible: Boolean) {
     dispatchOnPageReleaseCallback(collapseEligible)
 
-    if (!collapseEligible.not()) {
+    if (!collapseEligible.not()) {  // TODO: remove double negation.
       return
     }