Minor change: Use "args" where there is more than one "arg" #531
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit is not a bug fix.
sagiegurari
reviewed
Mar 10, 2021
src/lib/version.rs
Outdated
| .arg("search") | ||
| .arg("cargo-make") | ||
| .args(&["search", "cargo-make"]) |
There was a problem hiding this comment.
not sure this is more readable.... lets drop this one.
|
nice. is that a new function? don't remember it when i first developed cargo-make. |
Codecov Report
@@ Coverage Diff @@
## master #531 +/- ##
==========================================
- Coverage 92.92% 92.92% -0.01%
==========================================
Files 98 98
Lines 18677 18672 -5
==========================================
- Hits 17356 17351 -5
Misses 1321 1321
Continue to review full report at Codecov.
|
|
merging. thanks a lot for this quality change :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaced
args withargs.This commit is not a bug fix.