-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set up Issue Templates, PR Templates #86
Comments
The relationship between issues and PRs is still confusing to me. It seems so to many others. There is no such confusion in trac. So how about always requiring an issue for a PR? Then an issue template would correspond to the ticket description box, and a PR template correspond to, more or less, the ticket badges like build&test results and the documentation build results. Then the roles of an issue and a PR would be clearly separated. I fear that allowing a PR without an issue would cause unnecessary confusion... |
Actually we won't need such ticket badges in the description. The GH Actions checks appear in the Checks tab of a PR (sagemath/website#436) and while running and when failing also as PR events. |
I missed that. Right. Anyway the proposed PR templates here seem to have no substance. Perhaps we need no PR template at all. Requiring an issue for an PR may be too much; If the author needs it, then s/he can open an issue using the issue template, and link the issue with the PR. |
Improved version based on https://github.com/sagemath/sage-gh-templates-sandbox Fixes sagemath/trac-to-github#86. Co-authored-by: Matthias Köppe <mkoeppe@math.ucdavis.edu>
Improved version based on https://github.com/sagemath/sage-gh-templates-sandbox Fixes sagemath/trac-to-github#86. Co-authored-by: Matthias Köppe <mkoeppe@math.ucdavis.edu>
Issue and PR templates:
https://github.com/sagemath/sage-gh-templates-sandbox
https://github.com/sagemath/sage-gh-templates-sandbox/issues/new/choose
See https://docs.github.com/en/communities/using-templates-to-encourage-useful-issues-and-pull-requests/configuring-issue-templates-for-your-repository
Discussion: https://groups.google.com/g/sage-devel/c/2dKvRwdwVQM (2022-10)
The text was updated successfully, but these errors were encountered: