Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set up Issue Templates, PR Templates #86

Closed
mkoeppe opened this issue Jan 2, 2023 · 3 comments · Fixed by sagemath/sage#34983
Closed

Set up Issue Templates, PR Templates #86

mkoeppe opened this issue Jan 2, 2023 · 3 comments · Fixed by sagemath/sage#34983
Labels
help wanted Extra attention is needed

Comments

@mkoeppe mkoeppe added the help wanted Extra attention is needed label Jan 2, 2023
@mkoeppe mkoeppe added this to the After the migration milestone Jan 2, 2023
@kwankyu
Copy link

kwankyu commented Jan 5, 2023

The relationship between issues and PRs is still confusing to me. It seems so to many others. There is no such confusion in trac.

So how about always requiring an issue for a PR? Then an issue template would correspond to the ticket description box, and a PR template correspond to, more or less, the ticket badges like build&test results and the documentation build results. Then the roles of an issue and a PR would be clearly separated.

I fear that allowing a PR without an issue would cause unnecessary confusion...

@mkoeppe
Copy link
Author

mkoeppe commented Jan 5, 2023

[...] a PR template correspond to, more or less, the ticket badges like build&test results and the documentation build results

Actually we won't need such ticket badges in the description. The GH Actions checks appear in the Checks tab of a PR (sagemath/website#436) and while running and when failing also as PR events.

@kwankyu
Copy link

kwankyu commented Jan 5, 2023

I missed that. Right. Anyway the proposed PR templates here seem to have no substance. Perhaps we need no PR template at all.

Requiring an issue for an PR may be too much; If the author needs it, then s/he can open an issue using the issue template, and link the issue with the PR.

tobiasdiez added a commit to tobiasdiez/sage that referenced this issue Feb 6, 2023
Improved version based on https://github.com/sagemath/sage-gh-templates-sandbox
Fixes sagemath/trac-to-github#86.

Co-authored-by: Matthias Köppe <mkoeppe@math.ucdavis.edu>
alexjbest pushed a commit to alexjbest/sage that referenced this issue Feb 9, 2023
Improved version based on https://github.com/sagemath/sage-gh-templates-sandbox
Fixes sagemath/trac-to-github#86.

Co-authored-by: Matthias Köppe <mkoeppe@math.ucdavis.edu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants