This repository has been archived by the owner on Jun 18, 2020. It is now read-only.
Provisional workaround to sanitize rating comments #323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This works great for several such bad situations, and is clearly the "correct" way to fix this particular problem. Thank you! I will look at #324 eventually but will need to think more about when we want to sanitize and when not. |
kcrisman
added a commit
that referenced
this pull request
Dec 21, 2014
Provisional workaround to sanitize rating comments
migeruhito
added a commit
to migeruhito/sagenb
that referenced
this pull request
Jan 29, 2015
migeruhito
added a commit
to migeruhito/sagenb
that referenced
this pull request
Jan 29, 2015
migeruhito
added a commit
to migeruhito/sagenb
that referenced
this pull request
Sep 24, 2015
migeruhito
added a commit
to migeruhito/sagenb
that referenced
this pull request
Oct 24, 2015
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This solves (but not in an optimal manner) Issue #318. This problem arises because the jinja2 automatic autoescape (flask default) is disabled in the Notebook. The particular Notebook implementation needs this feature disabled in multiple points, despite it is a major security threat. This might be (as usually occurs) related to Issue #319.
This commit only sanitizes the particular point causing the problem, but automatic autoescape remains deactivated. Not good. I'm working in a better but more complex solution.